UX: Removing thread-pane "snap to last page" behavior

Andrew J. Buehler wanderer at fastmail.fm
Fri Jan 17 16:53:30 UTC 2014


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 01/17/2014 11:50 AM, Gervase Markham wrote:

> On 17/01/14 15:56, Andrew Sutherland wrote:
>
>> In https://bugzilla.mozilla.org/show_bug.cgi?id=920510 Andrew (Buehler)
>> made the padding configurable; presumably if you crank the values up you
>> could get f/b/n to show you more context.  See the constants at the top of:
>> https://hg.mozilla.org/comm-central/rev/1c6c0b697be4
> 
> This is definitely an improvement - I've set the value to 10 :-) Thanks,
> Andrew!
> 
> However, there doesn't seem to be any sanity checking which makes sure
> the message is always visible! If I set the bottom padding to a very
> large one, instead of pinning the message to the top, it's off-screen.

I originally included sanity checking for robustness, but got asked to
remove it during the review process.

The design of the patch changed at least once after that, but it
shouldn't be too hard to add the checks back in if necessary.

- --
  Andrew J. Buehler
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJS2WAJAAoJEASpNY00KDJr2M8P/1b4n6wMVo1CmPNm37NPB7oE
XgdKNg2OdKXZ0vy7wMWKWvGHQChcF2ILneRObyrnn13DSKOzhNakkO0DaXpNWP6F
hhhCoA5Md57b/pQeZp9zstE0ru8dnGClsrbTbQxx4s65BhOGJ6EYlrJsxdqApoVl
4kaLba6A6wmIrG+/+29xAVhL+UgxUnS3qvdqOCi83rL+2wFds7+UVQWznggjoGQp
e0L1Hly5IXJnHgbPT0UbDpUUiohinBA82BoAA4WX/Dmx1hj/MM0Wek61LC2w7r2b
Z4zg1kJJNp77CN0aeXSJBlq86sAbkB0bMdPLkRNaXbj1RQGhHErIGcMuAP3C4nyZ
oCtLaFKUvo/dCcyF6qmnJcDyBnRYbBM4gSNVUcGc8En2GgQvv2eyBEDG17QmUsDq
ZqCNUXowDFAHS2eFPCbNnQb3o1WetHIFFoT62K04q242mfttKby4BRUe9bQoGJwG
9UDCSdie4xa50LoGw/wg8Gb48WxuDBNgoVbCMgfDa7eU/VhIpb4YCQBruorXelSk
hX9GFyyot0Vwk9K2E9QujscAT9m++Kzv/HuulSD66lcwM4yPbcgPpWzwISzBCmP1
L2IuUFYFiZ4c0GG+VWbRRi1bASiBk4Ks2kWtw5e3A+Xbcp8lO0MFsGXCe7xcxy77
OVFxK6U+IrIhhd4wuy3I
=Ze6v
-----END PGP SIGNATURE-----



More information about the tb-planning mailing list