nsIEditor is now builtinclass

Jorge Villalobos jorge at mozilla.com
Fri Aug 29 23:18:12 UTC 2014


I looked up "nsIEditor" in the Add-ons MXR and saw various references to
it, but no add-ons implementing it. I can give access to this tool to
the Tb leadership (Kent may already have access because he was a reviewer).

Regards,

Jorge

On 8/28/14, 4:42 PM, Jonathan Protzenko wrote:
> For what it's worth, I'm not sure many addons do the whacky stuff that
> I'm doing, and having the interim fix of "make the editor field of
> nsIMsgCompose mutable" (bug 1059171) is good for me and doesn't
> require reverting the "make nsIEditor builtinclass" change.
>
> Jorge, do you have any way of examining the current addons for
> Thunderbird and figuring out which ones of these provide an
> implementation of nsIEditor?
>
> Thanks,
>
> ~ jonathan
>
> On 08/28/2014 10:24 PM, Ehsan Akhgari wrote:
>> On 2014-08-28, 3:54 PM, R Kent James wrote:
>>> On 8/26/2014 2:11 PM, Jonathan Protzenko wrote:
>>>> Here's the full explanation for the earlier initEditor breakage I
>>>> mentioned in my original mail below.
>>>>
>>>> tl;dr: nsIEditor is, as Ehsan kindly pointed out to me, now
>>>> builtinclass (can't be implemented in JS); a consequence is that
>>>> clients who wish to send HTML emails now really need to abide by one
>>>> very specific state protocol. A way to workaround this would be to
>>>> make the editor field of nsIMsgCompose read-write. Thoughts?
>>>>
>>>
>>> See *Bug 1059705*
>>> <https://bugzilla.mozilla.org/show_bug.cgi?id=1059705>
>>> -revert the change which made nsIEditor builtinclass and
>>> https://bugzilla.mozilla.org/show_bug.cgi?id=1053048#c29 "We can revert
>>> the change pretty easily though. Just tiny bit uglier C++ code, but
>>> that
>>> is fine."
>>>
>>> :smaug seems open to reverting this change. I hope that is what you
>>> wanted, protz!
>>
>> This is sort of terrible.  I was hoping to get to a better solution
>> here. :(
>>
>> Ehsan
>>
>




More information about the tb-planning mailing list