Directions for Thunderbird

Karsten Düsterloh mnyromyr at tprac.de
Mon Apr 4 18:44:33 UTC 2011


Ben Bucksch aber hob zu reden an und schrieb:
> Dev process
…
> But when trying to contribute, it turned out to be 
> impossible. Innovations (including contributions with 1000 lines of 
> code) are stopped short to a screeching halt in their tracks by the 
> review nit-picking procedures and test requirements. 

Part of the problematic state of /mailnews is the *lack* of such
requirements in the past. Dumping scarcely reviewed code inside a
codebase just because "it (mostly) works" is not a solution, it only
leads to major pain afterwards.

I agree, though, that writing meaningful tests often requires knowledge
of code dependencies which newbies usually don't have — probably even
much more knowledge than the limited scope of the bug they're fixing …
The actual patch probably should not necessarily be blocked by a missing
test, if the test still to come. (Yes, may be hard to tell.)


Karsten



More information about the tb-planning mailing list