Modal Dialog/Alert replacement suggestion - for 3.1?

Mark Banner mbanner at mozillamessaging.com
Mon Mar 22 22:41:07 UTC 2010


A couple of days ago over irc, timeless suggested a solution to fix Bug 
123440 <https://bugzilla.mozilla.org/show_bug.cgi?id=123440> - Stop that 
annoying modal dialog when mail can't connect to the mail server from 
connection time out error.

The basic idea is that all Mailnews modal dialogs go to the alerts 
service. I think this would mean they would appear in the same location 
as the new mail alert - certainly on Linux & Mac (not quite so sure 
about Windows, but probably!).

I say all Mailnews modal dialogs - afaik this pretty much encompasses 
all single button  - "OK" - dialogs that are generated from protocol 
errors and that end up going through nsIMsgMailSession::alertUser. I 
suspect there may be a few other modal dialog prompts that aren't 
covered by this.

Personally I'm not quite sure if I like the idea that all modal dialogs 
would go to the popup notification are, as there may be some instances 
that would make more sense to be a direct prompt to the user, but I 
think the basic idea is reasonable. I've generated some try server 
builds from the patch for people to try out and see what they think.

These ones are latest-trunk:

http://s3.mozillamessaging.com/build/try-server/2010-03-22_06:10-bugzilla@standard8.plus.com-alertService-trunk/bugzilla@standard8.plus.com-alertService-trunk-mail-try-win32.installer.exe
http://s3.mozillamessaging.com/build/try-server/2010-03-22_06:10-bugzilla@standard8.plus.com-alertService-trunk/bugzilla@standard8.plus.com-alertService-trunk-mail-try-mac.dmg
http://s3.mozillamessaging.com/build/try-server/2010-03-22_06:10-bugzilla@standard8.plus.com-alertService-trunk/bugzilla@standard8.plus.com-alertService-trunk-mail-try-linux.tar.bz2

Although this won't get into the 3.0.x series, I did some builds based 
on 3.0.4 in case people want to use those instead for testing:

http://s3.mozillamessaging.com/build/try-server/2010-03-22_12:40-bugzilla@standard8.plus.com-alertService-191-v2/bugzilla@standard8.plus.com-alertService-191-v2-mail-try-win32.installer.exe
http://s3.mozillamessaging.com/build/try-server/2010-03-22_12:40-bugzilla@standard8.plus.com-alertService-191-v2/bugzilla@standard8.plus.com-alertService-191-v2-mail-try-mac.dmg
http://s3.mozillamessaging.com/build/try-server/2010-03-22_12:40-bugzilla@standard8.plus.com-alertService-191-v2/bugzilla@standard8.plus.com-alertService-191-v2-mail-try-linux.tar.bz2

Feedback welcome. Note: I haven't put this in the bug for now, as it may 
not make 3.1 (depending on what we decide) and given the amount of noise 
in there recently, I don't want to add to it until we've got a better 
idea of where we want to go with this patch.

Mark.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.mozilla.org/pipermail/tb-planning/attachments/20100322/2e3e77d0/attachment.html>


More information about the tb-planning mailing list