MozMill just got stricter
sid1337 at gmail.com
Fri Apr 9 21:40:46 UTC 2010
With MozMill, we've tolerated timeouts in waitForEval calls so far.
However, with the landing of bug 540110 , MozMill now treats all
waitForEval timeouts as failures. This means that whatever state
waitForEval is waiting for *must* occur, otherwise the test will fail.
Not only does this mean quicker test runs (no more pesky ten-second
timeouts), the change exposed a few bugs in both our test harness and in
Thunderbird itself. They've all been fixed, though, so the tree is
currently green. However, MozMill tests in patches that haven't landed
yet might start to fail, so please fix them if they do.
Please also make sure any new waitForEval loops you spin also fail when
they time out. There are at least two ways to do it:
- You can call controller.js's waitForEval, e.g. .
- You can call waitForEval on a particular window controller, e.g. .
More information about the tb-planning