Edwin Smith edwsmith at
Thu Jan 10 07:51:38 PST 2008

I simply revert any changes to generated files before generating my
diffs for review.  

once we have the commandline tools in place (configure, make,
x-platform) i'm all for hg removing the generated files.

-----Original Message-----
From: tamarin-devel-bounces at
[mailto:tamarin-devel-bounces at] On Behalf Of Thomas Reilly
Sent: Wednesday, January 09, 2008 5:30 PM
To: Benjamin Smedberg
Cc: tamarin-devel at
Subject: RE: grrr...

Steven pointed out that the diff's of generated files are part of the
problem.  This would be core/vm_* and core/builtin_*.  What are moz's
practices on checking in generated files?   I'm against in general but
okay with it when the SCM knows when these files should be treated as
"binary".  Obviously we can't pull the generated pieces until the tools
to build them are available (asc.jar, we're working on it).  But lets
say asc.jar is readily attainable, should we yank these files from
source control?   Personally I'd like to see the build systems build
these files based on dependency rules so developers can avoid any files
out of date/sync issues.

-----Original Message-----
From: Benjamin Smedberg [mailto:benjamin at]
Sent: Wed 1/9/2008 2:10 PM
To: Thomas Reilly
Cc: tamarin-devel at
Subject: Re: grrr...
Hash: SHA1

Thomas Reilly wrote:

| I don't want to break my patch up, I just spent all this time getting
| to collapse it to one change!   I tried unselecting the patch thing
| the limit is lower for that.  Any suggestions?  Email it out?

Any one of

* compress it to patch.bz2
* put it on a website somewhere
* post a repository with the change

should work.

- --BDS

- --

Benjamin Smedberg
Platform Guru
Mozilla Corporation
benjamin at
Version: GnuPG v1.4.5 (Darwin)
Comment: Using GnuPG with Mozilla -


Tamarin-devel mailing list
Tamarin-devel at

More information about the Tamarin-devel mailing list