[rust-dev] Code review checklist
flaper87 at gmail.com
Wed Jan 22 00:41:26 PST 2014
2014/1/22 Brian Anderson <banderson at mozilla.com>
> Thanks. This is a good idea.
I added it to the Notes wiki page now!
Hope it helps!
> On 01/19/2014 04:52 AM, Flaper87 wrote:
> I've been doing reviews for a bit and I just realized we, as community,
> don't have a review checklist that all reviewers should go through. I
> thought that it could be useful to have a wiki page describing the review
> proces for newcomers and people willing to contribute with reviews.
> I wrote some points here based on what I've seen. I also added a
> section for non-core reviewers (people w/o r+ powers). In this section I
> just added 1 item in order for these group of folks (which I'm part of) to
> give their blessing to the patches they've reviewed. This will welcome more
> reviewes at the cost of adding more noise to the PR.
> Any comments are welcome. Also, it's a wiki page so feel free to improve
> it. I haven't linked it to the 'Notes for developers' page because I'd
> like it to be reviewed first.
>  https://github.com/mozilla/rust/wiki/Note-code-review
> Flavio (@flaper87) Percoco
> Rust-dev mailing listRust-dev at mozilla.orghttps://mail.mozilla.org/listinfo/rust-dev
> Rust-dev mailing list
> Rust-dev at mozilla.org
Flavio (@flaper87) Percoco
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Rust-dev