<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">I wanted to follow-up here in light of
the thread about Dawn and plans about aurora. You voiced concerns
there that longer nightly cycles would make the life of Photon
devs harder. I'd like to understand those concerns better. AIUI,
ifdefs and/or prefs would be workable and a longer nightly cycle
wouldn't really make a difference there, right? We'll have to
write the ifdefs/prefs anyway...<br>
<br>
Related brainwave: I wonder if we could have a general pref here
and expose it in CSS as a custom (-moz-photon) media query (via
small amounts of CSS c++ code hooked up to a prefcache). That
would avoid ifdefs for the CSS and would also avoid forks / custom
themes, and it would mean that toggling the pref would immediately
update the UI, more or less for free (minus invalidation issues,
which in an ideal world don't exist, but at least it won't be a
build-time switch!).<br>
<br>
In general, if it's possible to end up with pref switches rather
than ifdefs, that would be preferable, IMO, as it reduces the
threshold to test this stuff out, and makes it easier to quickly
test a change in both settings / versions, without rebuilding.<br>
<br>
~ Gijs<br>
<br>
On 30/03/2017 09:42, Dão Gottwald wrote:<br>
</div>
<blockquote
cite="mid:CACV3tysvAEaTkMd_chiaM=i9upWce7N9MyJc2YAbDo0gESrWbA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>It's quite possible. Could just be a different theme folder
with a build-time switch. However, I don't see how that's
better than a project branch. It seems like a different way to
fork stuff with roughly the same overhead due to having to
synchronize it.<br>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2017-03-30 0:04 GMT+02:00 Mike Conley <span
dir="ltr"><<a moz-do-not-send="true"
href="mailto:mconley@mozilla.com" target="_blank">mconley@mozilla.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div>
<div>
<div>Hey folks,<br>
<br>
</div>
Not sure if my suggestion got lost in the shuffle, or
if it's malodourous / obvious enough that it didn't
prompt reply, but would landing the appearance changes
as a new complete theme be out of the question? I know
we're tearing out the support for that stuff, at least
for third-party extensions, but for this kind of theme
development, it seems quite well suited.<br>
<br>
</div>
Or am I wrong?<span class="HOEnZb"><font color="#888888"><br>
<br>
</font></span></div>
<span class="HOEnZb"><font color="#888888">-Mike<br>
</font></span>
<div class="gmail_extra"><br>
<div class="gmail_quote">
<div>
<div class="h5">On 29 March 2017 at 08:37, Dão
Gottwald <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:dgottwald@mozilla.com"
target="_blank">dgottwald@mozilla.com</a>></span>
wrote:<br>
</div>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div class="h5">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote"><span>2017-03-29
14:18 GMT+02:00 Gijs Kruitbosch <span
dir="ltr"><<a
moz-do-not-send="true"
href="mailto:gkruitbosch@mozilla.com"
target="_blank">gkruitbosch@mozilla.com</a>></span>:<br>
<blockquote class="gmail_quote"
style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF"><span
class="m_-3879519158336224581m_-3541295394843722769gmail-">
<div
class="m_-3879519158336224581m_-3541295394843722769gmail-m_203763490791391469moz-cite-prefix">On
29/03/2017 11:42, Dão Gottwald
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">2017-03-28
14:22 GMT+02:00 Gijs
Kruitbosch <span
dir="ltr"><<a
moz-do-not-send="true"
href="mailto:gkruitbosch@mozilla.com" target="_blank">gkruitbosch@mozilla.com</a>></span>:<br>
<blockquote
class="gmail_quote"
style="margin:0px 0px
0px
0.8ex;border-left:1px
solid
rgb(204,204,204);padding-left:1ex"><span
class="m_-3879519158336224581m_-3541295394843722769gmail-m_203763490791391469gmail-">
On 28/03/2017 08:06,
Chris Peterson wrote:</span><span
class="m_-3879519158336224581m_-3541295394843722769gmail-m_203763490791391469gmail-"><br>
<blockquote
class="gmail_quote"
style="margin:0px
0px 0px
0.8ex;border-left:1px
solid
rgb(204,204,204);padding-left:1ex">
It seems like some
of the smaller
visible UI changes
could probably ship
in 55/56 without
needing a pref.
Users probably won't
notice some of the
UI polish features
until everything is
into place in 57.
Shipping these
smaller bits in
55/56 would give us
more testing. <br>
</blockquote>
</span> Can you
elaborate on this? What
are "small visible UI
changes" that users
"won't notice"? I'm
skeptical these even
exists, looking at (for
instance) things like <a
moz-do-not-send="true"
href="https://bugzilla.mozilla.org/show_bug.cgi?id=1345989"
rel="noreferrer"
target="_blank">https://bugzilla.mozilla.org/s<wbr>how_bug.cgi?id=1345989</a>
. <a
moz-do-not-send="true"
href="https://xkcd.com/1172/" rel="noreferrer" target="_blank">https://xkcd.com/1172/</a>
comes to mind... And
yes, of course these are
extreme examples, but
I'm also looking at the
mockups I've seen and
thinking I don't see
anything that falls in
the "small polish"
category in our main
theming & structural
changes.</blockquote>
<div><br>
</div>
</div>
You're reading Chris too
literally.</div>
</div>
</blockquote>
</span> I fail to understand what is
"literal" about my reading and how
yours is less so, and I'm
disappointed that you're turning an
honest question into "you're
(reading it) wrong".<br>
</div>
</blockquote>
<div><br>
<br>
</div>
</span>
<div>No need to take it personally, I was
just trying to answer your question.
Clearly, there is no UI change that is
guaranteed to go unnoticed with every
single user. Reworded as "most users
won't notice", are you still skeptical
that such changes exist?<br>
</div>
<span>
<div> </div>
<blockquote class="gmail_quote"
style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF">
<blockquote type="cite">
<div dir="ltr"><span
class="m_-3879519158336224581m_-3541295394843722769gmail-">
<div class="gmail_extra">
We're not trying to make it
look like there were no
changes at all between 54,
55 and 56, but the changes
shouldn't particularly stand
out and take away from
Photon.<br>
<br>
</div>
</span>
<div class="gmail_extra"><snip><br>
</div>
<span
class="m_-3879519158336224581m_-3541295394843722769gmail-">
<div class="gmail_extra">For
the visual refresh, I'm
trying to be smart and
divide the work into parts
that can be tackled early
and parts that should wait.
Nihanth is going to start
with integrating our new SVG
toolbar button icons in bug
1347543 -- this should land
when it's ready (I've
checked with shorlander,
he's fine with this)</div>
</span></div>
</blockquote>
<br>
I wouldn't have thought that
changing the icons over to the
Photon icon set would be something
we'd do before 57, as that's pretty
noticeable.<br>
<br>
(To be clear, I'm not arguing that
we shouldn't do this stuff prior to
57 if people are on board with it,
but to me this is a surprising
example of "small changes".)<span
class="m_-3879519158336224581m_-3541295394843722769gmail-HOEnZb"><font
color="#888888"><br>
</font></span></div>
</blockquote>
<div><br>
</div>
</span></div>
From what I've seen the icons are a bit
sharper and thinner, but in the grand scheme
of things it's a rather subtle and
incremental change.<br>
<br>
</div>
<div class="gmail_extra">dao<br>
</div>
</div>
<br>
</div>
</div>
<span class="">______________________________<wbr>_________________<br>
Photon-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:Photon-dev@mozilla.org"
target="_blank">Photon-dev@mozilla.org</a><br>
<a moz-do-not-send="true"
href="https://mail.mozilla.org/listinfo/photon-dev"
rel="noreferrer" target="_blank">https://mail.mozilla.org/listi<wbr>nfo/photon-dev</a><br>
<br>
</span></blockquote>
</div>
<br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Photon-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Photon-dev@mozilla.org">Photon-dev@mozilla.org</a>
<a class="moz-txt-link-freetext" href="https://mail.mozilla.org/listinfo/photon-dev">https://mail.mozilla.org/listinfo/photon-dev</a>
</pre>
</blockquote>
<p><br>
</p>
</body>
</html>