<div><div dir="auto">Hello Jared,</div><div dir="auto"><br></div><div dir="auto">I’ll review them. We solved some of them before. As I can remember I prepared some RTL guidelines for Firefox focus and Firefox for android before. I think we have to prepare a new one for this case.</div><div dir="auto"><br></div><div dir="auto">Bests,</div><div dir="auto">Reza</div></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Feb 7, 2020 at 11:37 AM Jared Wein <<a href="mailto:jaws@mozilla.com">jaws@mozilla.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)">I have taken a quick look through the Firefox UI and believe the following<br>
issues are present with RTL support (tested with intl.l10n.pseudo=bidi in<br>
about:config, then restarting):<br>
<br>
1. The "Show Sidebars" icon in the navigation toolbar should be flipped in<br>
RTL.<br>
2. The arrows for submenus in the menupopup for the Library button in the<br>
navigation toolbar are facing the wrong way.<br>
3. The arrows for submenus in the Firefox menu are facing the wrong way.<br>
4. The "external link" icon for Firefox Monitor and Firefox Send, found<br>
within the Account submenu of the Firefox menu are facing the wrong way.<br>
5. The "send tab to device" icon in the Account submenu of the Firefox menu<br>
is facing the wrong way.<br>
6. The magnifying glass in about:config is flipped when we normally<br>
wouldn't flip an icon that represents something from the physical world<br>
that is held by the majority of people in their right hand. In the linked<br>
MDN page has this topic in the "what to mirror" section, though the<br>
sub-referenced "material design" page mentions this as something to "not to<br>
mirror".<br>
7. The background for the tracker doorhanger's expanded info section in the<br>
location bar should have the shield on the left side in RTL.<br>
8. The "Print" icon should be flipped since the paper coming out of the<br>
printer shows directional text.<br>
9. The Pocket menu does not appear to have any RTL support.<br>
10. The "Pin tab", "Send tab to device", and "share" icons in the "..."<br>
menu of the location bar are facing the wrong way.<br>
11. The "Go" arrow in the search box that appears after the user starts<br>
typing is facing the wrong way in RTL.<br>
12. The "Last Page", "Next Page", "Previous Page", "First Page" icons in<br>
Print Preview are facing the wrong way in RTL.<br>
13. The submenu arrows in the Site Information popup are facing the wrong<br>
way.<br>
<br>
Icons I'm not sure about:<br>
1. The "protections report" icon shows a graph with the Y axis on the left<br>
side. Should this be flipped for RTL?<br>
<br>
Many of these would make good-first-bugs for people to mentor. Can someone<br>
look through this list and let me know if I got any of them wrong?<br>
<br>
Thanks,<br>
Jared<br>
<br>
<br>
On Thu, Feb 6, 2020 at 7:04 PM Tim Nguyen <<a href="mailto:ntim.bugs@gmail.com" target="_blank">ntim.bugs@gmail.com</a>> wrote:<br>
<br>
> Hello folks,<br>
><br>
> There has been a significant number of RTL bugs found in the last few<br>
> months in the Firefox UI. From what I can gather, they were mostly due lack<br>
> of awareness on specific situations that are more complex than just using<br>
> CSS logical properties, but sometimes due to lack of testing.<br>
><br>
> Itiel has made a great job at filing+fixing many bugs and wrote up a guide<br>
> based on his experience. This guide describes in detail what things should<br>
> be mirrored, text handling in RTL and tips on how to spot/fix/test RTL<br>
> issues. It includes things I personally didn't know about before, so I do<br>
> encourage giving it a read:<br>
><br>
> <a href="https://developer.mozilla.org/docs/Mozilla/Developer_guide/RTL_guidelines" rel="noreferrer" target="_blank">https://developer.mozilla.org/docs/Mozilla/Developer_guide/RTL_guidelines</a><br>
><br>
> When developing a new part of the UI or making significant UI changes,<br>
> please do make sure you manually test RTL for issues (by setting<br>
> intl.l10n.pseudo to bidi) to make Firefox accessible for all languages :)<br>
><br>
> I hope that this guide will be helpful, and please do let me or Itiel know<br>
> if you've got any feedback on it.<br>
><br>
> Cheers,<br>
> Tim,<br>
> Firefox Desktop Theme peer<br>
><br>
> _______________________________________________<br>
> firefox-dev mailing list<br>
> <a href="mailto:firefox-dev@mozilla.org" target="_blank">firefox-dev@mozilla.org</a><br>
> <a href="https://mail.mozilla.org/listinfo/firefox-dev" rel="noreferrer" target="_blank">https://mail.mozilla.org/listinfo/firefox-dev</a><br>
><br>
_______________________________________________<br>
dev-l10n mailing list<br>
<a href="mailto:dev-l10n@lists.mozilla.org" target="_blank">dev-l10n@lists.mozilla.org</a><br>
<a href="https://lists.mozilla.org/listinfo/dev-l10n" rel="noreferrer" target="_blank">https://lists.mozilla.org/listinfo/dev-l10n</a><br>
</blockquote></div></div>