<div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div>> Has any thought been given to xpcshell-tests? <br></div><div>No extra thoughts, but we normally have the same features as the connect page.</div><div>So if there's something that can't be done with the new about:debugging, that's a bug.<br></div><div><br></div><div>> Currently when you
run with --jsdebugger, it specifies using the Connect route which
was fairly easy. Maybe we could now change the tests to open
<a class="gmail-m_-606729062617139533moz-txt-link-freetext">about:debugging</a> (semi)automatically?</div><div>Yes we should do that, we missed this. At least update <a href="https://searchfox.org/mozilla-central/source/testing/xpcshell/head.js#437-444">https://searchfox.org/mozilla-central/source/testing/xpcshell/head.js#437-444</a>, and as you said maybe try to open about:debugging immediately, ideally with `localhost:6000` always added and ready to connect to.<br></div><div><br></div><div>> I've just tried the <a class="gmail-m_-606729062617139533moz-txt-link-freetext">about:debugging</a> page with an xpcshell-test,
and it will connect, but then you can't do anything -</div><div>> it complains
about the browser being an old version (I suspect this is because
xpcshell doesn't always have version information).</div><div>I suspect you want to target the main process here? Processes are hidden by default.</div><div>Can you try setting devtools.aboutdebugging.process-debugging to true in about:config and see if you can debug what you're interested in?</div><div>Good point about xpcshell not having the runtime info we expect for backward compat checks, we should probably special case it.<br></div><div><br></div><div>I managed to debug an xpcshell test with the new about:debugging:</div><div><div><img src="cid:ii_ju1ih00n0" alt="image.png" width="563" height="287"></div><div>The about:devtools-toolbox UI is a bit confused (header mostly), but debugging works.<br></div></div><div><br></div><div>> Also, where should bugs be filed, is there a meta they should be
filed against?</div><div>Yes! Please file bugs against our main meta <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=1462208">https://bugzilla.mozilla.org/show_bug.cgi?id=1462208</a>, we triage them twice a week.</div><div>I tried to compile the items raised here in <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=1541517">https://bugzilla.mozilla.org/show_bug.cgi?id=1541517</a>. Feel free to add to this bug or log other ones if relevant.<br></div><div><br></div><div>Thanks for the feedback!<br></div></div></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Apr 3, 2019 at 7:07 PM Mark Banner <<a href="mailto:mbanner@mozilla.com">mbanner@mozilla.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF">
<div class="gmail-m_-606729062617139533moz-cite-prefix">On 03/04/2019 07:58, Julian Descottes
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:700;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap">How to test the new <a class="gmail-m_-606729062617139533moz-txt-link-freetext">about:debugging</a></span>
<p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap">The new <a class="gmail-m_-606729062617139533moz-txt-link-freetext">about:debugging</a> is enabled in Nightly since the 1st of April. Open <a class="gmail-m_-606729062617139533moz-txt-link-freetext">about:debugging</a> on Nightly to test it out.</span></p>
<br>
<p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap">We might have missed something, which is why we need your feedback before we proceed to remove the feature (and the code) as we don’t want to disrupt your workflow.</span></p>
</div>
</blockquote>
<p>Has any thought been given to xpcshell-tests? Currently when you
run with --jsdebugger, it specifies using the Connect route which
was fairly easy. Maybe we could now change the tests to open
<a class="gmail-m_-606729062617139533moz-txt-link-freetext">about:debugging</a> (semi)automatically?<br>
</p>
<p>I've just tried the <a class="gmail-m_-606729062617139533moz-txt-link-freetext">about:debugging</a> page with an xpcshell-test,
and it will connect, but then you can't do anything - it complains
about the browser being an old version (I suspect this is because
xpcshell doesn't always have version information).</p>
<p>Also, where should bugs be filed, is there a meta they should be
filed against?</p>
<p>Thanks,</p>
<p>Mark<br>
</p>
</div>
_______________________________________________<br>
firefox-dev mailing list<br>
<a href="mailto:firefox-dev@mozilla.org" target="_blank">firefox-dev@mozilla.org</a><br>
<a href="https://mail.mozilla.org/listinfo/firefox-dev" rel="noreferrer" target="_blank">https://mail.mozilla.org/listinfo/firefox-dev</a><br>
</blockquote></div>