<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head><body style="font-family: tt;" text="#000000" bgcolor="#FFFFFF"><div
style="font-family: tt;"><span>Jean-Yves Avenard wrote on 3/7/18 6:23
am:</span><br><blockquote type="cite"
cite="mid:CA+phgpEky1rzdtshgGU1xUGU3SaJRbZL_ebxBxUp2PrgYLLUOQ@mail.gmail.com"><div
dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Jul
2, 2018 at 5:01 PM, Andreas Tolfsen <span dir="ltr"><<a
href="mailto:ato@sny.no" target="_blank" moz-do-not-send="true">ato@sny.no</a>></span>
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Also sprach Marco
Bonardo:<br>
<span class=""><br>
> When asking for review to multiple reviewers, and all of them must
accept<br>
> your revision, you must mark them as blocking reviews, either in
the<br>
> Phabricator ui or appending "!" at the end of the reviewer name.
Otherwise<br>
> it's first-come-first-serve.<br>
<br>
</span>Note that is and also has been the case for mozreview.<br></blockquote></div><div
class="gmail_quote"><br></div><div class="gmail_quote">I don't ever
recall mozreview having different kind of reviewer (blocker or
non-blocker), if two people were added as reviewer, by default both had
to review.</div></div></div></blockquote>it's correct that mozreview
(and bugzilla) only have one type of reviewer. what multiple reviewers
means in bugzilla/mozreview varies from team to team (all must review
vs. any can review).<br><br>it isn't correct that in mozreview two
reviewers would both have to review.<br>approval from _any_ reviewer
would allow it to be landed with autoland:<br><a class="moz-txt-link-freetext" href="https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/pylib/mozreview/mozreview/review_helpers.py#l34">https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/pylib/mozreview/mozreview/review_helpers.py#l34</a><br><br>i
like that phabricator makes this distinction up-front.<br>thanks mak
for drawing attention to this difference/feature.<br><br><br>-glob<br><div
class="moz-signature">-- <br><span style="color: rgb(192, 192, 192);">glob
— engineering workflow — moz://a</span><br>
<br>
</div></div></body></html>