<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Jun 8, 2018 at 5:34 AM, Gijs Kruitbosch <span dir="ltr"><<a href="mailto:gijskruitbosch@gmail.com" target="_blank">gijskruitbosch@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<p>In my most recent review in Phabricator/Differential, I noticed
it said "No Linters Available" in the top "Diff Detail" section.</p></div></blockquote><div>This is built into Phabricator and wouldn't come close to scaling to our needs.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF">
<p>Does this actually mean that eslint, the cpp warning checks (I
forget what that tool is called) and python linting won't run on
these commits and automatically post reviews like they do in
mozreview? (The commit in question only touched JS files so I
would have expected eslint to run;
<a class="m_3741579024942308176moz-txt-link-freetext" href="https://phabricator.services.mozilla.com/D1591" target="_blank">https://phabricator.services.<wbr>mozilla.com/D1591</a> in case it matters)</p></div></blockquote><div>If you mean the static analysis stuff that RelMan set up to run on MozReview, they are working on integrating that with Phabricator right now. :)<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF">
<p>If so, that too seems like a step back compared to mozreview...
If not, can we update the page to be less confusing? :-)<span class="HOEnZb"><font color="#888888"><br></font></span></p></div></blockquote><div><br></div><div>This is a standard thing in Phabricator so I don't know what we can do without further customizing our instance... though maybe we can somehow make it run a clearer no-op or otherwise provide a message indicating that static analysis will be run separately. Feel free to file a bug. :)<br></div><div><br></div><div>Mark</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF"><p><span class="HOEnZb"><font color="#888888">
</font></span></p><span class="HOEnZb"><font color="#888888">
<p>~ Gijs<br>
</p></font></span><div><div class="h5">
<div class="m_3741579024942308176moz-cite-prefix">On 06/06/2018 15:57, Mark Côté wrote:<br>
</div>
</div></div><blockquote type="cite"><div><div class="h5">
<div dir="ltr">The Engineering Workflow team is happy to announce
the release of Phabricator and Lando for general use. Going
forward, Phabricator will be the primary code-review tool for
modifications to the mozilla-central repository, replacing both
MozReview and Splinter. Lando is an all-new automatic-landing
system that works with Phabricator. This represents about a year
of work integrating Phabricator with our systems and building
out Lando. Phabricator has been in use by a few teams since last
year, and Lando has been used by the Engineering Workflow team
for several weeks and lately has successfully landed a few
changesets to mozilla-central.<br>
<br>
Phabricator is a suite of applications, but we are primarily
using the code-review tool, called Differential, which will be
taking the place of MozReview and Splinter. Bug tracking will
continue to be done with Bugzilla, which is integrated with
Phabricator. You will log into Phabricator via Bugzilla. We will
soon begin sunsetting MozReview, and Splinter will be made
read-only (or replaced with another patch viewer). An upcoming
post will outline the plans for the deprecation, archival, and
decommission of MozReview, with Splinter to follow.<br>
<br>
I also want to thank Phacility, the company behind Phabricator,
who provided both excellent support and work on Phabricator
itself to meet our requirements in an exceptionally helpful and
responsive way.<br>
<br>
User documentation on Phabricator catered specifically to
Mozillians can be found at <a href="https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html" target="_blank">https://moz-conduit.<wbr>readthedocs.io/en/latest/<wbr>phabricator-user.html</a>.
It is also linked from within Phabricator, in the left-hand menu
on the home page.<br>
<br>
User documentation on Lando can be found at <a href="https://moz-conduit.readthedocs.io/en/latest/lando-user.html" target="_blank">https://moz-conduit.<wbr>readthedocs.io/en/latest/<wbr>lando-user.html</a>.<br>
<br>
MDN documentation is currently being updated.<br>
<br>
At the moment, Phabricator can support confidential revisions
when they are associated with a confidential bug, that is, a bug
with one or more security groups applied. Lando, however, cannot
currently land these revisions. This is a limitation we plan to
fix in Q3. You can follow <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=1443704" target="_blank">https://bugzilla.mozilla.org/<wbr>show_bug.cgi?id=1443704</a>
for developments. See <a href="http://moz-conduit.readthedocs.io/en/latest/phabricator-user.html#landing-patches" target="_blank">http://moz-conduit.<wbr>readthedocs.io/en/latest/<wbr>phabricator-user.html#landing-<wbr>patches</a>
for our recommendations on landing patches in Phabricator
without Lando.<br>
<br>
Similarly, there are two other features which are not part of
initial launch but will follow in subsequent releases:<br>
* Stacked revisions. If you have a stack of revisions, that is,
two or more revisions with parent-child relationships, Lando
cannot land them all at once. You will need to individually
land them. This is filed as <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=1457525" target="_blank">https://bugzilla.mozilla.org/<wbr>show_bug.cgi?id=1457525</a>.
<br>
* Try support. Users will have to push to the Try server
manually until this is implemented. See <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=1466275" target="_blank">https://bugzilla.mozilla.org/<wbr>show_bug.cgi?id=1466275</a>.
<br>
<br>
Finally, we realize there are a few oddities with the UI that we
will also be fixing in parallel with the new features. See <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=1466120" target="_blank">https://bugzilla.mozilla.org/<wbr>show_bug.cgi?id=1466120</a>.<br>
<br>
The documentation lists several ways of getting in touch with
the Engineering Workflow team, but #phabricator and #lando on
IRC are good starting points.<br>
<br>
</div>
<br>
<fieldset class="m_3741579024942308176mimeAttachmentHeader"></fieldset>
</div></div><span class=""><pre class="m_3741579024942308176moz-quote-pre">______________________________<wbr>_________________
firefox-dev mailing list
<a class="m_3741579024942308176moz-txt-link-abbreviated" href="mailto:firefox-dev@mozilla.org" target="_blank">firefox-dev@mozilla.org</a>
<a class="m_3741579024942308176moz-txt-link-freetext" href="https://mail.mozilla.org/listinfo/firefox-dev" target="_blank">https://mail.mozilla.org/<wbr>listinfo/firefox-dev</a>
</pre>
</span></blockquote>
</div>
</blockquote></div><br></div></div>