<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>For linting/static analysis and for code coverage purposes, we
are affected by the lack of knowledge about what public revision a
Phabricator revision applies to (which is the same problem
blocking Try as far as I can tell). We are working around it by
always assuming the Phabricator revision applies on top of the
current mozilla-central tip, but this might fail in some cases.
Hopefully the solution implemented for Try will be reusable by us
too.</p>
<p>- Marco.<br>
</p>
<br>
<div class="moz-cite-prefix">Il 08/06/2018 11:38, Sylvestre Ledru ha
scritto:<br>
</div>
<blockquote type="cite"
cite="mid:%3C0d73e618-8036-f877-1174-9b42f5a80e02@mozilla.com%3E">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<p>Hello,</p>
<p>This is ongoing work. We already fixed a bunch of bugs
(phabricator API is very different from mozreview's).<br>
</p>
<p>Jan wrote a great summary of the current state: <a
class="moz-txt-link-freetext"
href="https://github.com/mozilla-releng/services/issues/1166"
moz-do-not-send="true">https://github.com/mozilla-releng/services/issues/1166</a><br>
</p>
<p>Hopefully, we will deploy it next week.<br>
</p>
<p>Cheers,<br>
Sylvestre</p>
<p><br>
</p>
<div class="moz-cite-prefix">Le 08/06/2018 à 11:34, Gijs
Kruitbosch a écrit :<br>
</div>
<blockquote type="cite"
cite="mid:12f7ce54-0789-c416-189e-8e4a5337e895@gmail.com">
<meta http-equiv="Content-Type" content="text/html;
charset=utf-8">
<p>In my most recent review in Phabricator/Differential, I
noticed it said "No Linters Available" in the top "Diff
Detail" section.</p>
<p>Does this actually mean that eslint, the cpp warning checks
(I forget what that tool is called) and python linting won't
run on these commits and automatically post reviews like they
do in mozreview? (The commit in question only touched JS files
so I would have expected eslint to run; <a
class="moz-txt-link-freetext"
href="https://phabricator.services.mozilla.com/D1591"
moz-do-not-send="true">https://phabricator.services.mozilla.com/D1591</a>
in case it matters)</p>
<p>If so, that too seems like a step back compared to
mozreview... If not, can we update the page to be less
confusing? :-)<br>
</p>
<p>~ Gijs<br>
</p>
<div class="moz-cite-prefix">On 06/06/2018 15:57, Mark Côté
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAPJZ0qRG5Qe0dHV6WNZ4PPpoOTzMD7jEzb6DMWfgw=eXwR-21g@mail.gmail.com">
<div dir="ltr">The Engineering Workflow team is happy to
announce the release of Phabricator and Lando for general
use. Going forward, Phabricator will be the primary
code-review tool for modifications to the mozilla-central
repository, replacing both MozReview and Splinter. Lando is
an all-new automatic-landing system that works with
Phabricator. This represents about a year of work
integrating Phabricator with our systems and building out
Lando. Phabricator has been in use by a few teams since last
year, and Lando has been used by the Engineering Workflow
team for several weeks and lately has successfully landed a
few changesets to mozilla-central.<br>
<br>
Phabricator is a suite of applications, but we are primarily
using the code-review tool, called Differential, which will
be taking the place of MozReview and Splinter. Bug tracking
will continue to be done with Bugzilla, which is integrated
with Phabricator. You will log into Phabricator via
Bugzilla. We will soon begin sunsetting MozReview, and
Splinter will be made read-only (or replaced with another
patch viewer). An upcoming post will outline the plans for
the deprecation, archival, and decommission of MozReview,
with Splinter to follow.<br>
<br>
I also want to thank Phacility, the company behind
Phabricator, who provided both excellent support and work on
Phabricator itself to meet our requirements in an
exceptionally helpful and responsive way.<br>
<br>
User documentation on Phabricator catered specifically to
Mozillians can be found at <a
href="https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html"
moz-do-not-send="true">https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html</a>.
It is also linked from within Phabricator, in the left-hand
menu on the home page.<br>
<br>
User documentation on Lando can be found at <a
href="https://moz-conduit.readthedocs.io/en/latest/lando-user.html"
moz-do-not-send="true">https://moz-conduit.readthedocs.io/en/latest/lando-user.html</a>.<br>
<br>
MDN documentation is currently being updated.<br>
<br>
At the moment, Phabricator can support confidential
revisions when they are associated with a confidential bug,
that is, a bug with one or more security groups applied.
Lando, however, cannot currently land these revisions. This
is a limitation we plan to fix in Q3. You can follow <a
href="https://bugzilla.mozilla.org/show_bug.cgi?id=1443704"
moz-do-not-send="true">https://bugzilla.mozilla.org/show_bug.cgi?id=1443704</a>
for developments. See <a
href="http://moz-conduit.readthedocs.io/en/latest/phabricator-user.html#landing-patches"
moz-do-not-send="true">http://moz-conduit.readthedocs.io/en/latest/phabricator-user.html#landing-patches</a>
for our recommendations on landing patches in Phabricator
without Lando.<br>
<br>
Similarly, there are two other features which are not part
of initial launch but will follow in subsequent releases:<br>
* Stacked revisions. If you have a stack of revisions, that
is, two or more revisions with parent-child relationships,
Lando cannot land them all at once. You will need to
individually land them. This is filed as <a
href="https://bugzilla.mozilla.org/show_bug.cgi?id=1457525"
moz-do-not-send="true">https://bugzilla.mozilla.org/show_bug.cgi?id=1457525</a>.
<br>
* Try support. Users will have to push to the Try server
manually until this is implemented. See <a
href="https://bugzilla.mozilla.org/show_bug.cgi?id=1466275"
moz-do-not-send="true">https://bugzilla.mozilla.org/show_bug.cgi?id=1466275</a>.
<br>
<br>
Finally, we realize there are a few oddities with the UI
that we will also be fixing in parallel with the new
features. See <a
href="https://bugzilla.mozilla.org/show_bug.cgi?id=1466120"
moz-do-not-send="true">https://bugzilla.mozilla.org/show_bug.cgi?id=1466120</a>.<br>
<br>
The documentation lists several ways of getting in touch
with the Engineering Workflow team, but #phabricator and
#lando on IRC are good starting points.<br>
<br>
</div>
<!--'"--><br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
firefox-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:firefox-dev@mozilla.org" moz-do-not-send="true">firefox-dev@mozilla.org</a>
<a class="moz-txt-link-freetext" href="https://mail.mozilla.org/listinfo/firefox-dev" moz-do-not-send="true">https://mail.mozilla.org/listinfo/firefox-dev</a>
</pre>
</blockquote>
<!--'"--><br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
firefox-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:firefox-dev@mozilla.org" moz-do-not-send="true">firefox-dev@mozilla.org</a>
<a class="moz-txt-link-freetext" href="https://mail.mozilla.org/listinfo/firefox-dev" moz-do-not-send="true">https://mail.mozilla.org/listinfo/firefox-dev</a>
</pre>
</blockquote>
</blockquote>
<br>
</body>
</html>