<div dir="ltr"><div>I was able to trigger the first error by disabling unified builds in dom/media/eme, and I filed <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=1447070">https://bugzilla.mozilla.org/show_bug.cgi?id=1447070</a> with a patch to add the include that I mentioned (which fixes that error for me).</div><div><br></div><div>Let's take this discussion over there (and/or to a new bug, if that one #include isn't sufficient to fix your second build error).<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 19, 2018 at 10:44 AM, Daniel Holbert <span dir="ltr"><<a href="mailto:dholbert@mozilla.com" target="_blank">dholbert@mozilla.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">For the first error, it looks like dom/media/eme/MediaKeySession.<wbr>h is missing an #include. It needs this to be added up top:<br><br>#include "DecoderDoctorLogger.h"<br><div><br></div><div>Does that help?<br></div><br>(I'm not as sure about the second error -- that one's in generated code. Maybe fixing the first error -- thereby making the MediaKeySession class more legit -- will fix that second error about a usage of that class, too?)<br><br><br><br></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Mon, Mar 19, 2018 at 9:51 AM, Charles G Robertson <span dir="ltr"><<a href="mailto:cgrobertson@suse.com" target="_blank">cgrobertson@suse.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"><div style="font-family:Helvetica,Arial,sans-serif;font-size:13px">Hi,<br><br>Can someone tell me why building Firefox 59 for 32bit fails? I'm building for a i586 target. Here are the errors I'm seeing:<br><br>14:16.91 In file included from /home/abuild/rpmbuild/BUILD/ob<wbr>j/dom/bindings/MediaKeysBindin<wbr>g.cpp:11:0,<br>14:16.91 from /home/abuild/rpmbuild/BUILD/ob<wbr>j/dom/bindings/UnifiedBindings<wbr>21.cpp:14:<br>14:16.91 /home/abuild/rpmbuild/BUILD/ob<wbr>j/dist/include/mozilla/dom/Med<wbr>iaKeySession.h:31:39: error: expected constructor, destructor, or type conversion before ';' token<br>14:16.91 DDLoggedTypeName(dom::MediaKey<wbr>Session);<br>14:16.91 <wbr> ^<br>14:16.91 /home/abuild/rpmbuild/BUILD/ob<wbr>j/dist/include/mozilla/dom/Med<wbr>iaKeySession.h:47:35: error: expected template-name before '<' token<br>14:16.91 , public DecoderDoctorLifeLogger<MediaK<wbr>eySession><br>14:16.91 <wbr> ^<br>14:16.91 /home/abuild/rpmbuild/BUILD/ob<wbr>j/dist/include/mozilla/dom/Med<wbr>iaKeySession.h:47:35: error: expected '{' before '<' token<br>14:16.91 /home/abuild/rpmbuild/BUILD/ob<wbr>j/dist/include/mozilla/dom/Med<wbr>iaKeySession.h:47:35: error: expected unqualified-id before '<' token<br>14:17.19 libdom_svg.a.desc<br>14:19.54 libeditor_txtsvc.a.desc<br>14:22.64 In file included from /home/abuild/rpmbuild/BUILD/ob<wbr>j/dist/include/jsapi.h:17:0,<br>14:22.64 from /home/abuild/rpmbuild/BUILD/mo<wbr>zilla/dom/bindings/AtomList.h:<wbr>10,<br>14:22.65 from /home/abuild/rpmbuild/BUILD/ob<wbr>j/dom/bindings/MediaKeySystemA<wbr>ccessBinding.cpp:3,<br>14:22.65 from /home/abuild/rpmbuild/BUILD/ob<wbr>j/dom/bindings/UnifiedBindings<wbr>21.cpp:2:<br>14:22.65 /home/abuild/rpmbuild/BUILD/ob<wbr>j/dist/include/mozilla/RefPtr.<wbr>h: In instantiation of 'static void mozilla::RefPtrTraits<U>::Rele<wbr>ase(U*) [with U = mozilla::dom::MediaKeySession]<wbr>':<br>14:22.65 /home/abuild/rpmbuild/BUILD/ob<wbr>j/dist/include/mozilla/RefPtr.<wbr>h:398:40: required from 'static void RefPtr<T>::ConstRemovingRefPtr<wbr>Traits<U>::Release(U*) [with U = mozilla::dom::MediaKeySessi <wbr> on; T = mozilla::dom::MediaKeySession]<wbr>'<br>14:22.65 /home/abuild/rpmbuild/BUILD/ob<wbr>j/dist/include/mozilla/RefPtr.<wbr>h:79:44: required from 'RefPtr<T>::~RefPtr() [with T = mozilla::dom::MediaKeySession]<wbr>'<br>14:22.65 /home/abuild/rpmbuild/BUILD/ob<wbr>j/dom/bindings/MediaKeysBindin<wbr>g.cpp:257:94: required from here<br>14:22.65 /home/abuild/rpmbuild/BUILD/ob<wbr>j/dist/include/mozilla/RefPtr.<wbr>h:41:11: error: invalid use of incomplete type 'class mozilla::dom::MediaKeySession'<br>14:22.65 aPtr->Release();<br>14:22.65 ~~~~~~^~~~~~~<br></div>
<br></div></div>______________________________<wbr>_________________<br>
firefox-dev mailing list<br>
<a href="mailto:firefox-dev@mozilla.org" target="_blank">firefox-dev@mozilla.org</a><br>
<a href="https://mail.mozilla.org/listinfo/firefox-dev" rel="noreferrer" target="_blank">https://mail.mozilla.org/listi<wbr>nfo/firefox-dev</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br></div>