<div dir="ltr"><div>Hi,</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Apr 13, 2017 at 6:09 AM, Fischer Liu <span dir="ltr"><<a href="mailto:fliu@mozilla.com" target="_blank">fliu@mozilla.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">We are using dom.ipc.processCount to limit the count of process.<br>
After updating dom.ipc.processCount, do we still need to restart Firefox?<br>
<br></blockquote><div><br></div><div>It depends. It will prevent any new processes to be launched that would go beyond the new limit right away, but it will not shut down any existing processes if the current number is above the limit. For that you must either close tabs or restart the browser.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
As I know in PreallocatedProcessManagerImpl<wbr>::AllocateNow[2] and<br>
PreallocatedProcessManagerImpl<wbr>::RereadPrefs, there would read the pref to<br>
check the max count to allow creation or close process.<br>
<br>
[1]<br>
<a href="https://dxr.mozilla.org/mozilla-central/rev/f40e24f40b4c4556944c762d4764eace261297f5/dom/ipc/PreallocatedProcessManager.cpp#143" rel="noreferrer" target="_blank">https://dxr.mozilla.org/<wbr>mozilla-central/rev/<wbr>f40e24f40b4c4556944c762d4764ea<wbr>ce261297f5/dom/ipc/<wbr>PreallocatedProcessManager.<wbr>cpp#143</a><br>
 [2]<br>
<a href="https://dxr.mozilla.org/mozilla-central/rev/f40e24f40b4c4556944c762d4764eace261297f5/dom/ipc/PreallocatedProcessManager.cpp#200" rel="noreferrer" target="_blank">https://dxr.mozilla.org/<wbr>mozilla-central/rev/<wbr>f40e24f40b4c4556944c762d4764ea<wbr>ce261297f5/dom/ipc/<wbr>PreallocatedProcessManager.<wbr>cpp#200</a><br>
<br></blockquote><div><br></div><div>The preallocated process manager is not enabled yet on any channels by default, I'm still struggling with some failing tests and other issues with it. Hopefully that'll be fixed soon (<font size="2"><a class="gmail-m_-5982621178700164273bz_bug_link gmail-m_-5982621178700164273bz_status_NEW" title="NEW - [e10s-multi] Use the preallocated process manager by default" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1341008" target="_blank">Bug 1341008</a></font>), I wish I had more time for it... Once it's turned on, it will detect the change of the pref and shut down the preallocated process if necessary just like you described.<br></div><div> </div>Gabor<br></div></div></div>