<div dir="ltr"><div><div>Sounds like a good change to make from the discussion so far.<br><br></div>If
there are issues with stack traces, I would assume having more of our
code base using async / await is a good way to apply pressure for stack
trace improvements (if needed) that will benefit everyone.<br><br></div>- Ryan<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Mar 16, 2017 at 5:52 PM, Kris Maglione <span dir="ltr"><<a href="mailto:kmaglione@mozilla.com" target="_blank">kmaglione@mozilla.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Thu, Mar 16, 2017 at 05:39:06PM -0500, J. Ryan Stinnett wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
For modules that have already converted, is there any performance change<br>
(good or bad) between async / await vs. Task?<br>
</blockquote>
<br></span>
I haven't noticed any differences either way, but I also haven't done any explicit profiling. There's definitely a difference in the way we collect async stacks in async/await code vs. with the Promise.jsm promises that Task.jsm uses, but that shouldn't show up much on release.<div class="HOEnZb"><div class="h5"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Thu, Mar 16, 2017 at 5:33 PM, Kris Maglione <<a href="mailto:kmaglione@mozilla.com" target="_blank">kmaglione@mozilla.com</a>><br>
wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Thu, Mar 16, 2017 at 03:29:15PM -0700, Dave Townsend wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Writing code in standard JS is always better for the web, makes it easier<br>
to onboard new engineers and allows for better support in developer tools.<br>
So I'd like to propose that we switch to the standard way of writing these<br>
functions immediately. New code should use async/await instead of Task.jsm<br>
going forwards.<br>
<br>
</blockquote>
<br>
+1<br>
<br>
I've already started doing this in places where using Task.jsm was<br>
unwieldy, and it's improved things tremendously.<br>
</blockquote></blockquote>
</div></div></blockquote></div><br></div>