<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">+1<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 22 Feb 2017, at 11:09, Gijs Kruitbosch <<a href="mailto:gijskruitbosch@gmail.com" class="">gijskruitbosch@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
<meta http-equiv="content-type" content="text/html; charset=utf-8" class="">
<div bgcolor="#FFFFFF" text="#000000" class=""><p class="">Hello firefox-dev,</p><p class="">A while back I tried to start moving (browser) mochitests out of
browser/base/content/test/general/ to more topical directories. To
copy my reasoning from the original metabug:</p><div class="">
<br class="webkit-block-placeholder"></div><blockquote type="cite" class="">
<meta http-equiv="content-type" content="text/html;
charset=utf-8" class="">
</blockquote>
<blockquote type="cite" class="">It takes ages to run [locally], there's a
lot of tests that can influence each other, it's hard to isolate
a problem if tests do influence each other, it's hard to run
tests relevant for the change you're making, it takes long on
infra, if something breaks (cough bug 1253956 cough) everything
gets mass-disabled... there are a lot of reasons to not want to
have a directory with over 300 tests in.</blockquote><div class=""><br class="webkit-block-placeholder"></div><p class="">To add to that: browser mochitests are some of our slowest tests.
As far as I can tell, the mochitest-bc chunk on infra that
contains general/ right now *runs no other directories at all*. On
<a href="https://public-artifacts.taskcluster.net/KIBQPE3_QZCAnjxL8jd9zA/0/public/logs/live_backing.log" class="">linux
e10s debug</a>, that directory takes 50 minutes (3400s) to run.<br class="">
</p><p class="">There are a lot more topical subdirs now, and there's really no
good reason, IMO, to keep adding random tests to this directory.
Which does seem to keep happening: while the number of tests was
266 after I moved 40-odd tests to the urlbar/ directory 10 months
ago, and more tests were moved out of general/ since, the number
of tests in general/ right now is 267 (we'll run a ~90% subset of
those depending on platform, debug on/off and e10s on/off).<br class="">
</p><p class="">I'd like to add a commit/push hook that makes adding more tests
impossible unless you include some magic words, similar to the
webidl DOM peer review hooks.<br class="">
</p><p class="">Would anyone object to this happening?</p></div></div></blockquote></div><div>Heck no.</div><br class=""></div><div class="">Cheers,</div><div class=""><br class=""></div><div class="">Mike.</div></body></html>