<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Right bug (I assume)<br>
<a class="moz-txt-link-freetext" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1294568">https://bugzilla.mozilla.org/show_bug.cgi?id=1294568</a><br>
</div>
<blockquote type="cite"
cite="mid:CALXJ5sptvQDrhekwS5VEO6SMgCszSjapMvXgsDLxXSjcp07ZxA@mail.gmail.com">
<div dir="ltr">
<div>That doesn't seem to be the right bug # ...<br>
<br>
</div>
The higher order of the same question is that there seem to be
too much things to check manually, both for reviewers or patch
authors. This is probably the fact of life of UI programming,
but I wish these "things to note" can be represented in a more
concentrated places than mailing list threads. It would
definitely helps more if we are talking about "go faster", and
when every review round trip cause a day for engineers in Asia!<br>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Thu, Oct 20, 2016 at 5:23 PM, Dão
Gottwald <span dir="ltr"><<a
href="mailto:dgottwald@mozilla.com" target="_blank"
moz-do-not-send="true">dgottwald@mozilla.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div>Scanning for hardcoded colors is likely unfeasible.
Realistically we can't replace all of them, and if used
carefully they shouldn't be a problem.<br>
<br>
</div>
mozscreenshots potentially supports testing in high
contrast mode, but alas, that's currently not enabled: <a
href="https://bugzilla.mozilla.org/show_bug.cgi?id=129456"
target="_blank" moz-do-not-send="true">https://bugzilla.mozilla.org/<wbr>show_bug.cgi?id=129456</a></div>
<div class="HOEnZb">
<div class="h5">
<div class="gmail_extra"><br>
<div class="gmail_quote">2016-10-20 8:11 GMT+02:00 Tim
Guan-tin Chien <span dir="ltr"><<a
href="mailto:timdream@mozilla.com"
target="_blank" moz-do-not-send="true">timdream@mozilla.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div>Great write-up and nice work!<br>
</div>
I wonder what more we could do than "...keep
this in mind when writing and reviewing
patches"? Can we scan for hardcoded colors in
tests? Do a screenshot comparison?
<div>
<div class="m_916013142001342104h5"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Thu, Oct 13,
2016 at 4:05 AM, Mike de Boer <span
dir="ltr"><<a
href="mailto:mdeboer@mozilla.com"
target="_blank"
moz-do-not-send="true">mdeboer@mozilla.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote"
style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div>\o/ Nice work, Dão! I really like
the before/ after screenshots, they
really show the improvements made
for the share of users that are,
unfortunately, visually impaired.
<div>
<div><br>
</div>
<div>I’ll be keeping this in mind
and will probably reach out to
you soon for your advise in
making sure the findbar
highlighter supports high
contrast modes properly too ;-)</div>
<div><br>
</div>
<div>Cheers,</div>
<div><br>
</div>
<div>Mike.</div>
<div>
<div><br>
<div>
<blockquote type="cite">
<div>
<div
class="m_916013142001342104m_3569765648494150155m_8755120343686529529gmail-m_-1481934204066169300h5">
<div>On 12 Oct 2016,
at 14:02, Dão
Gottwald <<a
href="mailto:dgottwald@mozilla.com"
target="_blank"
moz-do-not-send="true">dgottwald@mozilla.com</a>>
wrote:</div>
<br
class="m_916013142001342104m_3569765648494150155m_8755120343686529529gmail-m_-1481934204066169300m_-8556237349771626606Apple-interchange-newline">
</div>
</div>
<div>
<div>
<div
class="m_916013142001342104m_3569765648494150155m_8755120343686529529gmail-m_-1481934204066169300h5">
<div dir="ltr">
<div>Over the last
quarter, I've
been focused on
making Firefox
properly support
high contrast
mode again. The
tracking bug for
this is <<a
href="https://bugzilla.mozilla.org/show_bug.cgi?id=1016556"
target="_blank" moz-do-not-send="true">https://bugzilla.mozilla.org/<wbr>show_bug.cgi?id=1016556</a>>.<br>
<br>
In case you
didn't know,
high contrast
mode is a
collection of
Windows themes
tailored for
users with not
so good
eyesight: <a
href="https://support.microsoft.com/en-us/help/13862/windows-use-high-contrast-mode"
target="_blank" moz-do-not-send="true">https://support.microsoft.com/<wbr>en-us/help/13862/windows-use-h<wbr>igh-contrast-mode</a><br>
<br>
</div>
There are four
high contrast
themes available,
three of which
have black as
their base color
and one
black-on-white
variant: <a
href="http://thewindowsclub.thewindowsclubco.netdna-cdn.com/wp-content/uploads/2015/01/high-contrast-themes-windows.jpg"
target="_blank"
moz-do-not-send="true">http://thewindowsclub.thewindo<wbr>wsclubco.netdna-cdn.com/wp-con<wbr>tent/uploads/2015/01/high-cont<wbr>rast-themes-windows.jpg</a><br>
<div>
<div><br>
High contrast
mode
considered an
important
accessibility
feature.
Formally we
have always
supported
this, but in
reality our
support has
been far from
perfect and in
many cases
gotten worse
over the
years.<br>
<br>
Here are a few
screenshots to
illustrate
what kinds of
bugs we've
fixed:<br>
<br>
Menu bar,
search bar and
<a
moz-do-not-send="true">about:home</a>
(before): <a
href="http://imgur.com/vMXgZMm" target="_blank" moz-do-not-send="true">http://imgur.com/vMXgZMm</a><br>
Menu bar,
search bar and
<a
moz-do-not-send="true">about:home</a>
(after): <a
href="http://imgur.com/a4Volo5"
target="_blank" moz-do-not-send="true">http://imgur.com/a4Volo5</a><br>
Menu panel and
customize mode
(before): <a
href="http://imgur.com/iBXWbeA" target="_blank" moz-do-not-send="true">http://imgur.com/iBXWbeA</a><br>
Menu panel and
customize mode
(after): <a
href="http://imgur.com/n881M4v"
target="_blank" moz-do-not-send="true">http://imgur.com/n881M4v</a><br>
<br>
As you can
see, issues
range from
text being
completely
illegible and
icons
disappearing,
over icons and
text lacking
contrast, to
some parts of
the UI not
adjusting at
all to high
contrast
themes.<br>
<br>
Support still
isn't perfect
but a lot
better than it
used to be.
Going forward
we as a team
will need to
remind
ourselves that
high contrast
mode is a
thing and that
we're
committed to
supporting it.
Please keep
this in mind
when writing
and reviewing
patches.
Please test
your features
in high
contrast mode.<br>
<br>
You might want
to take a look
at the fixed
bugs to get a
sense of
what's needed
to support
high contrast
mode. It often
comes down to
picking
platform
colors instead
of hardcoding
color values,
or carefully
picking color
values that
don't assume
that everyone
is using the
same default
OS theme. If
you're unsure
what's needed
to make your
feature
properly
support high
contrast mode,
feel free to
ask me for
feedback.<br>
<br>
Regards,<br>
Dao<br>
</div>
</div>
</div>
</div>
</div>
______________________________<wbr>_________________<br>
firefox-dev mailing list<br>
<a
href="mailto:firefox-dev@mozilla.org"
target="_blank"
moz-do-not-send="true">firefox-dev@mozilla.org</a><br>
<a
href="https://mail.mozilla.org/listinfo/firefox-dev"
target="_blank"
moz-do-not-send="true">https://mail.mozilla.org/listi<wbr>nfo/firefox-dev</a><br>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
<br>
______________________________<wbr>_________________<br>
firefox-dev mailing list<br>
<a
href="mailto:firefox-dev@mozilla.org"
target="_blank"
moz-do-not-send="true">firefox-dev@mozilla.org</a><br>
<a
href="https://mail.mozilla.org/listinfo/firefox-dev"
rel="noreferrer" target="_blank"
moz-do-not-send="true">https://mail.mozilla.org/listi<wbr>nfo/firefox-dev</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
firefox-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:firefox-dev@mozilla.org">firefox-dev@mozilla.org</a>
<a class="moz-txt-link-freetext" href="https://mail.mozilla.org/listinfo/firefox-dev">https://mail.mozilla.org/listinfo/firefox-dev</a>
</pre>
</blockquote>
<br>
</body>
</html>