<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">\o/ Nice work, Dão! I really like the before/ after screenshots, they really show the improvements made for the share of users that are, unfortunately, visually impaired.<div class=""><div class=""><br class=""></div><div class="">I’ll be keeping this in mind and will probably reach out to you soon for your advise in making sure the findbar highlighter supports high contrast modes properly too ;-)</div><div class=""><br class=""></div><div class="">Cheers,</div><div class=""><br class=""></div><div class="">Mike.</div><div class=""><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 12 Oct 2016, at 14:02, Dão Gottwald <<a href="mailto:dgottwald@mozilla.com" class="">dgottwald@mozilla.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="">Over the last quarter, I've been focused on making Firefox properly support high contrast mode again. The tracking bug for this is <<a href="https://bugzilla.mozilla.org/show_bug.cgi?id=1016556" class="">https://bugzilla.mozilla.org/show_bug.cgi?id=1016556</a>>.<br class=""><br class="">In case you didn't know, high contrast mode is a collection of Windows themes tailored for users with not so good eyesight: <a href="https://support.microsoft.com/en-us/help/13862/windows-use-high-contrast-mode" class="">https://support.microsoft.com/en-us/help/13862/windows-use-high-contrast-mode</a><br class=""><br class=""></div>There are four high contrast themes available, three of which have black as their base color and one black-on-white variant: <a href="http://thewindowsclub.thewindowsclubco.netdna-cdn.com/wp-content/uploads/2015/01/high-contrast-themes-windows.jpg" class="">http://thewindowsclub.thewindowsclubco.netdna-cdn.com/wp-content/uploads/2015/01/high-contrast-themes-windows.jpg</a><br class=""><div class=""><div class=""><br class="">High contrast mode considered an important accessibility feature. Formally we have always supported this, but in reality our support has been far from perfect and in many cases gotten worse over the years.<br class=""><br class="">Here are a few screenshots to illustrate what kinds of bugs we've fixed:<br class=""><br class="">Menu bar, search bar and <a href="about:home" class="">about:home</a> (before): <a href="http://imgur.com/vMXgZMm" class="">http://imgur.com/vMXgZMm</a><br class="">Menu bar, search bar and <a href="about:home" class="">about:home</a> (after): <a href="http://imgur.com/a4Volo5" class="">http://imgur.com/a4Volo5</a><br class="">Menu panel and customize mode (before): <a href="http://imgur.com/iBXWbeA" class="">http://imgur.com/iBXWbeA</a><br class="">Menu panel and customize mode (after): <a href="http://imgur.com/n881M4v" class="">http://imgur.com/n881M4v</a><br class=""><br class="">As you can see, issues range from text being completely illegible and icons disappearing, over icons and text lacking contrast, to some parts of the UI not adjusting at all to high contrast themes.<br class=""><br class="">Support still isn't perfect but a lot better than it used to be. Going forward we as a team will need to remind ourselves that high contrast mode is a thing and that we're committed to supporting it. Please keep this in mind when writing and reviewing patches. Please test your features in high contrast mode.<br class=""><br class="">You might want to take a look at the fixed bugs to get a sense of what's needed to support high contrast mode. It often comes down to picking platform colors instead of hardcoding color values, or carefully picking color values that don't assume that everyone is using the same default OS theme. If you're unsure what's needed to make your feature properly support high contrast mode, feel free to ask me for feedback.<br class=""><br class="">Regards,<br class="">Dao<br class=""></div></div></div>
_______________________________________________<br class="">firefox-dev mailing list<br class=""><a href="mailto:firefox-dev@mozilla.org" class="">firefox-dev@mozilla.org</a><br class="">https://mail.mozilla.org/listinfo/firefox-dev<br class=""></div></blockquote></div><br class=""></div></div></div></body></html>