<div dir="ltr"><div>I would also be fine with a new Control Center bugzilla component. Firefox::General is too big and Firefox::Security is not always appropriate (e.g. for UI glitches in the CC). We should be lenient with the bugs that end up there, I doubt bug filers will be aware of the distinction between identity block, identity panel and control center. Occasionally moving bugs to or from the Location Bar component shouldn't be a big deal.<br><br>I believe Paolo is already triaging the Downloads Panel component, so I nominate Johann for the role of Control Center Bugmeister. <br><br></div>Panos<br><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 16, 2016 at 1:18 PM, Gijs Kruitbosch <span dir="ltr"><<a href="mailto:gijskruitbosch@gmail.com" target="_blank">gijskruitbosch@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><span class="">
<div>On 16/08/2016 05:52, Matthew N. wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">On Sat, Aug 13, 2016 at 6:10 AM, Gijs
Kruitbosch <span dir="ltr"><<a href="mailto:gijskruitbosch@gmail.com" target="_blank">gijskruitbosch@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br>
<br>
How would people feel about creating a new (Firefox)
bugzilla component for control center? At the moment it
seems like all the bugs end up either in General or in
Location Bar (and some maybe in Device Permissions?), none
of which is a great fit. It seems like it'd make sense for
the feature to have its own component </blockquote>
<div><br>
In general I'm in favour of more focused components rather
than dumping grounds like Firefox::General and
Firefox::Security
<div style="font-family:arial,helvetica,sans-serif;display:inline" class="gmail_default"> as I think it makes finding
existing bugs and therefore triage easier. It also
makes it easier to prioritize buckets/themes of bugs.<br>
</div>
</div>
</div>
</div>
</div>
</blockquote></span>
Concur, this was my main motivation for proposing this change.<span class=""><br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div>
<div style="font-family:arial,helvetica,sans-serif" class="gmail_default">
<div class="gmail_quote">On Mon, Aug 15, 2016 at 10:11
AM, Brian Grinstead <span dir="ltr"><<a href="mailto:bgrinstead@mozilla.com" target="_blank">bgrinstead@mozilla.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span></span><span><br>
</span>It makes sense to me. I take it the proposed
split here is that bugs to do with #identity-box
belong in Location Bar and bugs to do with UI inside
the control center popup belong in this new
component?<br>
</blockquote>
<div><br>
</div>
<div>That's one way that would make sense though maybe
the permission request anchors shouldn't be part of
that since they're actually a different panel? It
seems like there are three related UI pieces: <br>
* identity block (which is where requests are
anchored)<br>
* identity panel <br>
* permission requests (which use the toolkit
PopupNotifications.jsm module with bugs in the
Toolkit::Notifications and Alerts component and have
some bugs in Firefox::Device Permissions)<br>
<br>
Do we want all three of those UI pieces in one
component? I think I lean towards yes since icons in
the identity box can sometimes open the identity
panel and sometimes be the anchor for a permission
request and bug filers probably won't understand the
distinction. When the permission icon isn't the
anchor of a request (e.g. a strike-through on the
geolocation icon) it's synchronized with state in
the identity panel and so they probably belong in
the same component. With all three of those pieces
in one new component I think the only remaining use
of the Device Permissions component would be for UI
outside the browser window indicating devices in use
and so that component could be renamed or removed.<br>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<br></span>
I would also lean towards putting everything in one component, and
that the distinction between one-off PopupNotifications.jsm-based
things and the "main" identity panel / control center is subtle
enough that we should probably deal with it all in one component. I
guess a decision about the remaining use of the Device Permissions
component could be best made by Florian (who is on PTO at the
moment).<span class=""><br>
<br>
<div>On 15/08/2016 18:15, Emma Humphries
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Two questions:<br>
<br>
</div>
<div class="gmail_default" style="font-family:arial,helvetica,sans-serif">1. Is there an
existing component that this would replace, or get merged into
the new component? I just get concerned with component-sprawl
in bugzilla.<br>
</div>
</div>
</blockquote></span>
I think at the moment Firefox doesn't have too many components,
especially if we don't count devtools (which I would personally
support moving to a separate product, but that's a separate topic).
Core might be a different story. Or maybe I am just experiencing
Stockholm Syndrome in that I am too used to the current system? :-)<br>
<br>
Out of the choice of the "component-sprawl" and "bug sprawl"
problems, I would prefer the former, especially with the new triage
responsibility scheme. In this scheme having more (and therefore
smaller) components is better, because it makes it easier to
distribute the triage decision-making both from a "this person owns
triage for this component" perspective (which is hard if the
component is huge because of the amount of work) and from a "it's
easy to have context for triage decisions" perspective (which is
also hard if the component is huge - how do you prio between
thousands of bugs without getting stuck in bikeshed-land?).<span class=""><br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_default" style="font-family:arial,helvetica,sans-serif">2. Who'd be
responsible for triaging bugs in this component? <br>
</div>
</div>
</blockquote></span>
The folks working on Control Center. Up to them to work out exactly
who would be where in the responsibility scheme - I'm not one of the
people working on it, I just keep seeing bugs filed in
Firefox::General and I would like to avoid that (see Matt's comment
and my response).<span class="HOEnZb"><font color="#888888"><br>
<br>
~ Gijs<br>
</font></span></div>
<br>______________________________<wbr>_________________<br>
firefox-dev mailing list<br>
<a href="mailto:firefox-dev@mozilla.org">firefox-dev@mozilla.org</a><br>
<a href="https://mail.mozilla.org/listinfo/firefox-dev" rel="noreferrer" target="_blank">https://mail.mozilla.org/<wbr>listinfo/firefox-dev</a><br>
<br></blockquote></div><br></div>