<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 18/07/2016 21:56, Gregory Szorc
wrote:<br>
</div>
<blockquote
cite="mid:CAJTgH0nrLivGNUZXUqgQ1wD6J19TaVc6Y3n6=AZUTi866JHBMA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">On Thu, Jul 14, 2016 at 1:54 AM, Gijs
Kruitbosch <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:gijskruitbosch@gmail.com" target="_blank">gijskruitbosch@gmail.com</a>></span>
wrote:<span class=""></span><br>
<span class=""></span>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"><span
class="">
On 13/07/2016 22:10, Gregory Szorc wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
First, *I would like to encourage Firefox developers
to prepare for the future by stopping to use fx-team*.
Don't `hg pull` from fx-team: base your work on
mozilla-central instead. Use MozReview + Autoland to
land your commits (they will land in the
integration/autoland repo).<br>
</blockquote>
</span>
This is not possible for all commits (*cough* security
bugs *cough*). I would really like that to get fixed, but
until it does, I continue to be, to borrow some song
lyrics "stuck in the middle" between a painful manual
upload process and one I shouldn't use for the thing I'm
doing.<br>
</blockquote>
<div><br>
</div>
<div>Security bugs are special. Since the majority of
commits aren't tied to security bugs, I don't think we
should let a minority use case have tyranny over the
majority. So let's ignore them for purposes of this
discussion.<br>
</div>
</div>
</div>
</div>
</blockquote>
But a significant portion of some people's commits are tied to
security bugs, and so those people are unhappy. I also wasn't
exactly suggesting tyranny, just pointing out that it's not possible
to use autoland without using mozreview, which in turn isn't
possible for some bugs. Why not decouple autoland from mozreview?
That would also make "land my amended patch" easier - it's basically
the same as (1) in the list of suggestions. If "hg push -r . review
--autoland" guaranteed to land my patch "soon" then I could use that
for a security bug after I got review via splinter, but at the
moment I can't even do that - I have to land it manually instead.<br>
<blockquote
cite="mid:CAJTgH0nrLivGNUZXUqgQ1wD6J19TaVc6Y3n6=AZUTi866JHBMA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Even where it *is* possible to use autoland, it's often
just more hassle to use autoland. Folks were surprised
recently when I pointed out my dashboards in mozreview
were useless because I have hundreds and hundreds of
"open" review requests. This is why. Common situation:<br>
</blockquote>
<div><br>
</div>
<div>FWIW MozReview review requests are closed automatically
when using autoland, making your dashboard usable.<br>
</div>
</div>
</div>
</div>
</blockquote>
I'm well aware of this, my point was that if I don't use autoland
they are not closed, and in too many cases autoland is the worse
option, and the result is a useless dashboard.<br>
<blockquote
cite="mid:CAJTgH0nrLivGNUZXUqgQ1wD6J19TaVc6Y3n6=AZUTi866JHBMA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">Recommendations in decreasing order
of effectiveness:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
1) with level 3 commit access it should be possible for me
to push-to-get-this-autolanded from the commandline, much
like I can push to try. I should not need my web browser
at that stage of the process.<br>
</blockquote>
<div><br>
</div>
<div>I agree.<br>
</div>
</div>
</div>
</div>
</blockquote>
So is there a bug on file on making this more sane? Should I file
one?<br>
<blockquote
cite="mid:CAJTgH0nrLivGNUZXUqgQ1wD6J19TaVc6Y3n6=AZUTi866JHBMA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
2) don't block autoland UI in mozreview on open issues,
just warn rather than disabling it outright.<br>
</blockquote>
<div><br>
</div>
<div>Please file a bug on this if there isn't already.<br>
</div>
</div>
</div>
</div>
</blockquote>
<a class="moz-txt-link-freetext" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1288136">https://bugzilla.mozilla.org/show_bug.cgi?id=1288136</a><br>
<br>
<blockquote
cite="mid:CAJTgH0nrLivGNUZXUqgQ1wD6J19TaVc6Y3n6=AZUTi866JHBMA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
3) if hard to do, at least provide the autoland link from
diff views, and just make mozreview do the 'Hi, I'm gonna
push these things' collating all items, maybe with a big
red warning if there's more than 1 cset in there.<br>
</blockquote>
<div><br>
</div>
<div>Yeah, I'm not sure why the automation entry isn't on
the diffs pages. I agree it should be there. A bug should
be filed.<br>
</div>
</div>
</div>
</div>
</blockquote>
This was already on file.
<a class="moz-txt-link-freetext" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1232703">https://bugzilla.mozilla.org/show_bug.cgi?id=1232703</a> . I've pinged
the assignee, david walsh, for updates, as it's been sitting there
for the last 2 months, AFAICT.<br>
<blockquote
cite="mid:CAJTgH0nrLivGNUZXUqgQ1wD6J19TaVc6Y3n6=AZUTi866JHBMA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">It doesn't sound like your concerns
block the removal of fx-team however: if you don't want to
use MozReview+Autoland, you can just substitute inbound for
fx-team and continue working like you currently do.<br>
</div>
</div>
</div>
</blockquote>
But I do want to use autoland. I use it pretty regularly. Sometimes
it's a non-great option even though I 'want' to use it. That's not
the same thing as not wanting to.<br>
<br>
I also pointed out that inbound is inferior to fx-team both in terms
of closure rates and in terms of stability. So practically speaking,
"just substituting" one for the other leads to a deterioration in my
effectiveness because the tools at my disposal just got worse.<br>
<br>
I guess I'm more likely to substitute central instead, but that is
also annoying because I can't push from it, and going from central
to inbound in the same working directory invalidates my builds and
means I then waste 20 minutes on a clobber - that or I have to do
another "hg share" to have a dedicated "for pushing" working
directory, and hop around between them whenever I push, which also
feels like a chore.<br>
<br>
Effectively, I'm having to pile workaround on workaround. I can do
that, but I would prefer for the autoland story to get better
sooner. How many people are working on that? Can we increase
whatever that number is so it stops being non-great for a number of
common usecases?<br>
<br>
~ Gijs<br>
</body>
</html>