<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
span.hoenzb
{mso-style-name:hoenzb;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;
color:black;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body bgcolor=white lang=EN-CA link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D;mso-fareast-language:EN-US'>Hoye and I have talked about the latter idea a few times. I think it’s definitely a significant investment, but it would radically open up our contributor base to a set of contributors who simply don’t and won’t have a modern developer-class PC to build the full tree on.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D;mso-fareast-language:EN-US'>If it’s good enough, it’d also be a vastly preferable option for a class of people who _<i>can</i>_ build the full tree, but really don’t need to deal with that much overhead. I’d count myself among that group, actually! <o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D;mso-fareast-language:EN-US'>-- Mike<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:windowtext'>From:</span></b><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:windowtext'> firefox-dev [mailto:firefox-dev-bounces@mozilla.org] <b>On Behalf Of </b>Gijs Kruitbosch<br><b>Sent:</b> October 17, 2014 12:48 PM<br><b>To:</b> Manish Goregaokar; Ehsan Akhgari<br><b>Cc:</b> Josh Matthews; Mike Hoye; Georg Fritzsche; Gregory Szorc; Firefox Dev<br><b>Subject:</b> Re: Nightly with unzipped omni.ja<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><div><p class=MsoNormal>If we decide to go this route, we should really ensure that this is not the default configuration, or we'll all have broken tests on aurora to look forward to (I've seen tests work against flat chrome but not against omni.ja, depending on how much introspection they end up doing and/or how they set paths and such).<br><br>Also, even if we did this, we'd still need a way to get the patches to work, esp. what with preprocessing and such (for most of our front-end JS and CSS), they just won't apply (and will be in the wrong format etc. etc.). Plus folks would have to turn off xul cache in order for things to work reliably after a restart.<br><br>Generally, I'm conflicted about this idea: it's fairly low-hanging to implement, but it's still pretty kludgy, and it will encourage more kludginess to make it work "better".<br><br>On the other hand, doing something that feels neater (e.g.: create an m-c clone with just the (non-compiled/c++/c) contents of toolkit/ and browser/, keep it in sync with m-c every day, and maintain a build script that can rebuild just these files into the omni.ja file/gredir for an existing build) will require more engineering investment.<br><br>I'm not sure where the right tradeoff is. While they're not mutually exclusive, I worry that choosing kludginess now will have us stuck with it even if/when we get better solutions.<br><br>~ Gijs<br><br>On 17/10/2014 09:32, Manish Goregaokar wrote:<o:p></o:p></p></div><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><div><p class=MsoNormal>Yeah, but to do any kind of <i>building</i> we still need a build system and an initial build, which takes forever to set up. I'm proposing we distribute nightly binaries with the omni.ja stuff flat.<o:p></o:p></p></div><div><p class=MsoNormal><br clear=all><o:p></o:p></p><div><div><p class=MsoNormal>-Manish Goregaokar<o:p></o:p></p></div></div><p class=MsoNormal><o:p> </o:p></p><div><p class=MsoNormal>On Fri, Oct 17, 2014 at 9:23 PM, Ehsan Akhgari <<a href="mailto:ehsan.akhgari@gmail.com" target="_blank">ehsan.akhgari@gmail.com</a>> wrote:<o:p></o:p></p><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm'><div><p class=MsoNormal>Wouldn't building with --enable-chrome-format=flat give you what you want? That option at least used to avoid creating the omni.ja package altogether and instead put normal files in your objdir which you could edit and restart Firefox to see the affects of (while of course getting rid of the XUL cache, etc.)<o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p><div><div><div><p class=MsoNormal>On Fri, Oct 17, 2014 at 11:27 AM, Manish Goregaokar <<a href="mailto:manishsmail@gmail.com" target="_blank">manishsmail@gmail.com</a>> wrote:<o:p></o:p></p></div></div><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm'><div><div><div><div><div><p class=MsoNormal style='margin-bottom:12.0pt'>Many contributors only stick to editing js/css/XUL. They don't really <i>need</i> a full build system for this, since these files are dynamically loaded at runtime.<br><br>However, these files are stored in the two omni.ja files. It's both <a href="https://developer.mozilla.org/en-US/docs/Mozilla/About_omni.ja_%28formerly_omni.jar%29" target="_blank">hard to extract that file, and hard to compress it</a> (perhaps impossible on Windows?). It's also <a href="http://inpursuitoflaziness.blogspot.in/2014/01/editing-files-from-omnija-in-firefox-20.html" target="_blank">completely non intuitive how to instruct Firefox to reload the file after editing</a>.<o:p></o:p></p></div><p class=MsoNormal>Would it be possible to provide nightlies of Firefox with unpacked omni.ja files without the js binaries? (Even better, have the files in the same directory structure as the original source)<o:p></o:p></p></div><div><p class=MsoNormal style='margin-bottom:12.0pt'>It would really improve the getting-started curve since new contributors can start tinkering without having to wait for a build.<o:p></o:p></p></div><div><p class=MsoNormal>mhoye had come up with this idea in a past thread where we were discussing startup hurdles, I just remembered it now when I needed to test something on Windows without a build system (another benefit of this -- UI patches can be tested and tweaked without a build system)<o:p></o:p></p></div><div><p class=MsoNormal><span style='color:#888888'><br clear=all><o:p></o:p></span></p><div><div><div><div><p class=MsoNormal><span style='color:#888888'>-Manish Goregaokar<o:p></o:p></span></p></div></div></div></div></div></div><p class=MsoNormal><o:p> </o:p></p></div></div><p class=MsoNormal style='margin-bottom:12.0pt'>_______________________________________________<br>firefox-dev mailing list<br><a href="mailto:firefox-dev@mozilla.org" target="_blank">firefox-dev@mozilla.org</a><br><a href="https://mail.mozilla.org/listinfo/firefox-dev" target="_blank">https://mail.mozilla.org/listinfo/firefox-dev</a><o:p></o:p></p></blockquote></div><p class=MsoNormal><span style='color:#888888'><br><br clear=all><br><span class=hoenzb>-- </span></span><span class=hoenzb><span style='color:#888888'><o:p></o:p></span></span></p><div><p class=MsoNormal><span style='color:#888888'>Ehsan</span><o:p></o:p></p></div></div></blockquote></div><p class=MsoNormal><o:p> </o:p></p></div><p class=MsoNormal><br><br><br><o:p></o:p></p><pre>_______________________________________________<o:p></o:p></pre><pre>firefox-dev mailing list<o:p></o:p></pre><pre><a href="mailto:firefox-dev@mozilla.org">firefox-dev@mozilla.org</a><o:p></o:p></pre><pre><a href="https://mail.mozilla.org/listinfo/firefox-dev">https://mail.mozilla.org/listinfo/firefox-dev</a><o:p></o:p></pre></blockquote><p class=MsoNormal><o:p> </o:p></p></div></body></html>