<div dir="ltr"><div>Sure.<br>I just wanted t be certain which one is in error here. If it has been implemented only in Firefox OS then the MDN page has to be edited but along with that the changelog page for Firefox 26 release too, right?<br><br></div>Confirming since that is supposed to be a release note, so don't want to edit it unless I am sure what I am doing :)<br></div><div class="gmail_extra"><br clear="all"><div><div dir="ltr"><div>Regards,<br></div>Rabimba Karanjai<br><br><img src="https://affiliates.mozilla.org/media/uploads/image_banners/803bf99f9621164871eacd1251079ebb63861c00.png" alt=""><img src="https://affiliates.mozilla.org/media/uploads/image_banners/803bf99f9621164871eacd1251079ebb63861c00.png" alt=""><a href="https://affiliates.mozilla.org/referral/64564/" target="_blank"><img alt="Firefox Marketplace" src="http://image.slidesharecdn.com/firefoxmarketplace-140703170744-phpapp02/95/firefox-marketplace-1-638.jpg?cb=1404425414" height="72" width="96"></a><br></div></div>
<br><div class="gmail_quote">On Tue, Sep 16, 2014 at 11:23 AM, Ehsan Akhgari <span dir="ltr"><<a href="mailto:ehsan.akhgari@gmail.com" target="_blank">ehsan.akhgari@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">These are documentation bugs. And MDN is a wiki. Please feel free to fix them. :-)<br></div><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">On Mon, Sep 15, 2014 at 9:22 AM, Rabimba Karanjai <span dir="ltr"><<a href="mailto:karanjai.moz@gmail.com" target="_blank">karanjai.moz@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div><div>Sorry for the misunderstanding in that case.<br></div>But just before the Gecko Note you can see the browser comparability section stating it is compatible starting from Firefox 26 (the default implementation). And I am in the "Desktop" tab<br><br><img src="cid:ii_i03ub4sg0_14879792f302182a" height="193" width="556"><br><br></div>Also following the link takes me to the release notes section for Firefox 26 which has this note "The <a href="https://developer.mozilla.org/en-US/docs/Web/API/Screen.orientation" title="The Screen.orientation property give the current orientation of the screen." target="_blank"><code>Screen.orientation</code></a> property and <a href="https://developer.mozilla.org/en-US/docs/Web/API/Screen.lockOrientation" title="The lockOrientation method locks the screen into the specified orientation." target="_blank"><code>Screen.lockOrientation()</code></a> method now support the <code>default</code> value, mapping to <code>portrait-primary</code> or <code>landscape-primary</code>, depending of the device (<a href="https://bugzilla.mozilla.org/show_bug.cgi?id=908058" title="FIXED: add orientation keyword 'default' to express normal orientation" target="_blank">bug 908058</a>)"<br></div>Which you can see from this screenshot<br><br></div><img src="cid:ii_i03uc9u71_148797a1274f2cc1" height="251" width="556"><br><div>Though the bug number (which I mentioned in my original post) does take this to the Firefox OS bug.<br></div></div><div class="gmail_extra"><span><br clear="all"><div><div dir="ltr"><div>Regards,<br></div>Rabimba Karanjai<br><br><img src="https://affiliates.mozilla.org/media/uploads/image_banners/803bf99f9621164871eacd1251079ebb63861c00.png" alt=""><img src="https://affiliates.mozilla.org/media/uploads/image_banners/803bf99f9621164871eacd1251079ebb63861c00.png" alt=""><a href="https://affiliates.mozilla.org/referral/64564/" target="_blank"><img alt="Firefox Marketplace" src="http://image.slidesharecdn.com/firefoxmarketplace-140703170744-phpapp02/95/firefox-marketplace-1-638.jpg?cb=1404425414" height="72" width="96"></a><br></div></div>
<br></span><div><div><div class="gmail_quote">On Mon, Sep 15, 2014 at 3:08 AM, Kevin Brosnan <span dir="ltr"><<a href="mailto:kbrosnan@gmail.com" target="_blank">kbrosnan@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>The MDN docs clearly state "<b>Gecko notes</b> This API is currently in draft form. It is only implemented as a prefixed method (mozLockOrientation) in B2G and Firefox for Android."<span><font color="#888888"><br><br></font></span></div><span><font color="#888888">Kevin<br></font></span></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Sep 15, 2014 at 12:06 AM, Kevin Brosnan <span dir="ltr"><<a href="mailto:kbrosnan@gmail.com" target="_blank">kbrosnan@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Bug 908058 looks to implement it for Firefox on Android and Firefox OS only. I don't see a desktop implementation in that code.<br><br></div>Kevin<br></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div>On Fri, Sep 12, 2014 at 5:20 PM, Rabimba Karanjai <span dir="ltr"><<a href="mailto:karanjai.moz@gmail.com" target="_blank">karanjai.moz@gmail.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div dir="ltr"><br><div class="gmail_quote"><div dir="ltr"><div><div><div><div>Hi,<br><br></div>I had a little query about the Screen.lockOrientation() API.<br></div>I just had a review of one of my apps published in the marketplace (which right now is in private status) that it was working perfectly in FirefoxOS but not in Firefox Desktop.<br></div>Upon investigating the issue I found out that my implementation of Screen.lockOrientation() is not working in the desktop browser. While I can certainly conditionally disable it, I just found out <a href="https://developer.mozilla.org/en-US/docs/Web/API/Screen.lockOrientation" target="_blank">this</a> developer documentation in <a href="https://developer.mozilla.org/en-US/docs/Web/API/Screen.lockOrientation" target="_blank">MDN</a>. The browser compatibility section states that it has been implemented in the browser since v26 (related to the resolved <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=908058" target="_blank"><b>Bug 908058</b></a>).<br><br></div>My implementation is (pretty straightforward)<br><br>var orientation = function() {<br> if (window.screen.mozLockOrientation('portrait')) {<br> // orientation was locked<br> } else {<br> screen.lockOrientation('portrait');<br> }<br>}<br><div><div><div><div><div><br></div><div>Am I doing something wrong here? Otherwise was the bug only related to FirefoxOS(b2g) and not Firefox OS.<br><br clear="all"><div><div dir="ltr"><div>Regards,<br></div>Rabimba Karanjai<br><br><img alt=""><img alt=""><a href="https://affiliates.mozilla.org/referral/64564/" target="_blank"><img alt="Firefox Marketplace" height="72" width="96"></a><br></div></div>
</div></div></div></div></div></div>
</div><br></div>
<br></div></div>_______________________________________________<br>
firefox-dev mailing list<br>
<a href="mailto:firefox-dev@mozilla.org" target="_blank">firefox-dev@mozilla.org</a><br>
<a href="https://mail.mozilla.org/listinfo/firefox-dev" target="_blank">https://mail.mozilla.org/listinfo/firefox-dev</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
firefox-dev mailing list<br>
<a href="mailto:firefox-dev@mozilla.org" target="_blank">firefox-dev@mozilla.org</a><br>
<a href="https://mail.mozilla.org/listinfo/firefox-dev" target="_blank">https://mail.mozilla.org/listinfo/firefox-dev</a><br>
<br></blockquote></div><br><br clear="all"><br></div></div><span class="HOEnZb"><font color="#888888">-- <br><div dir="ltr">Ehsan<br></div>
</font></span></div>
</blockquote></div><br></div>