<html><head></head><body>I'd echo this concern about overhead. The wins from PNG compression are nice to have, but on a per-image basis are relatively negligible, and we don't change images that often. Given that, running pngcrush on all images on all checkins seems a lot like overkill.<br>
<br>
I like the idea of tacking it onto the HSTS/blocklist update commit. Doing this once a week seems like more than enough to ensure a general state of good repair in terms of our image inventory. For bonus points we could tack it onto the train merge work flow to ensure late changes don't make it to release, but I don't think this is essential, since in the worst case late image additions would get cleaned up in the next release.<br>
<br>
Of course, this is all sanity checking, and we can also hand our visual designers a script to automate this prior to attaching images in the first place. That was standard practice a while back, at least.<br>
<br>
- Mike<br><br><div class="gmail_quote">Justin Dolske <dolske@mozilla.com> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 9/11/13 3:36 PM, Gregory Szorc wrote:<br /><br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">[...] If you check in an unoptimized file, TBPL goes green or orange.<br />Think FAIL_ON_WARNINGS. We could even do it selectively, per-directory,<br />per-file, etc.</blockquote><br />I'm a bit wary of the overhead per-run, since AFAIK the only way to <br />determine if an image is optimized is to try and optimize it again (and <br />see if it's unchanged). We've got ~1300 PNG files in m-c relevant to <br />themes (plus whatever B2G has).<br /><br />But a quick'n'dirty test seems to show that pngcrush, at least, is quite <br />fast, so performance may not be a concern.<br /><br />Justin<br /><hr /><br />firefox-dev mailing list<br />firefox-dev@mozilla.org<br /><a href="https://mail.mozilla.org/listinfo/firefox-dev">https://mail.mozilla.org/listinfo/firefox-dev</a><br
/></pre></blockquote></div><br>
-- <br>
Sent from my Android device with K-9 Mail. Please excuse my brevity.</body></html>