<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 22/04/13 23:23, Mike de Boer wrote:<br>
</div>
<blockquote
cite="mid:0AD2069C-7152-424E-928F-C9FCA4BE8306@mozilla.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
I see I have done a poor job at showing a good & proper
example, so please take a look at this:
<div><br>
</div>
<div>
<ul class="MailOutline">
<li><a moz-do-not-send="true"
href="https://github.com/mikedeboer/mozAsync/blob/master/examples/browser_aboutHome.orig.js">https://github.com/mikedeboer/mozAsync/blob/master/examples/browser_aboutHome.orig.js</a></li>
<li><a moz-do-not-send="true"
href="https://github.com/mikedeboer/mozAsync/blob/master/examples/browser_aboutHome.js">https://github.com/mikedeboer/mozAsync/blob/master/examples/browser_aboutHome.js</a></li>
</ul>
<div><br>
</div>
<div>This is the browser_aboutHome.js unit test code vs. a
rewritten version with AsyncTest.</div>
<div><br>
</div>
<div>The NLOC difference is minimal (~100 lines), but the more
significant improvement here is the structure that is proposed
as uniform.</div>
<br>
</div>
</blockquote>
I love the idea of a standardized organization of the tests, though
I honestly find the original implementation with Task far easier to
follow in this example. What I'd really love is something like
add_task that made xpcshell tests much better to read and write.<br>
We should probably try to get the best out of the 2 worlds, keep the
simple sequential logic of Task with a better defined way to declare
the tests and unified async utils.<br>
<br>
-m<br>
</body>
</html>