<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">On Mar 20, 2013, at 5:10 AM, Gavin Sharp <<a href="mailto:gavin@mozilla.com">gavin@mozilla.com</a>> wrote:<blockquote type="cite">I think this is a "does it look alright" ui-review rather than a "should we do this" UI-review, at this point.</blockquote><div><br></div><div>It's actually a little bit of both :)</div><div><br></div><div>As far as looking ok; it does! With the one minor thing I mentioned to Marco about a strange jittery panel bug on OS X that I can't seem to capture in a screen recording. It is quite visible on screen though.</div><div><br></div><div>"Should we do this" is a little more complicated. I think yes, we should move it into its own button and out of the awesomebar and combine the two things into one mega-button of bookmarking awesomeness. When we were testing it there were a few problems brought up with the interaction. 1) some worry that combining them won't be obvious 2) the bookmark menu is a pretty highly used item and we will be making the hit target much smaller while the star is less commonly used and will be larger.</div><div><br></div><div>We have a few ideas for refinement, but I would be ok pushing it as is if we could iterate on it afterwards. I don't know if that will be more or less tedious than unbitrotting the current patch?</div><div><br></div><div><br></div><div>Also uploading the try-builds here since they probably have expired: <a href="http://people.mozilla.org/~shorlander/Bookmark-Star-Builds/">http://people.mozilla.org/~shorlander/Bookmark-Star-Builds/</a></div><div><br></div><div>Should be ready in about 10 minutes.</div><div><br></div><div><br></div><div>Thanks!</div><div>- Stephen</div></div></div><div><br></div><br><div><div>On Mar 20, 2013, at 11:45 AM, Madhava Enros <<a href="mailto:madhava@mozilla.com">madhava@mozilla.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">
<div>
Screenshots are always helpful, but I'll have a look at the bug and comment there if we need them.
</div><div><br></div><div>Thanks for pointing this out!</div><div><br></div><div>Madhava</div>
<div><div><br></div><div>-- </div><div>Madhava Enros</div><div>Firefox User Experience</div><div><a href="http://mozilla.org/firefox">mozilla.org/firefox</a></div><div><br></div></div><p style="color: #A0A0A8;">On Wednesday, March 20, 2013 at 5:10 AM, Gavin Sharp wrote:</p>
<blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px;">
<span><div>Hey Stephen,</div><div><br></div><div>Marco and Mano tell me that bug 748894's patch (moving the bookmark star outside of the URL bar to the toolbar) keeps bitrotting and is getting to be a pain to maintain. It's mostly blocked on ui-review.</div><div><br></div><div>I think this is a "does it look alright" ui-review rather than a "should we do this" UI-review, at this point. Anything we can do to help expedite the review? Maybe screenshots on the bug would be useful?</div><div><br></div><div>Gavin</div></span>
</blockquote>
<div>
<br>
</div>
</blockquote></div><br></body></html>