<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 20/03/13 16:59, Stephen Horlander
wrote:<br>
</div>
<blockquote
cite="mid:6DFFC7ED-3277-4CD6-9E44-1183531F75CB@mozilla.com"
type="cite">
<div>
<div style="word-wrap: break-word; -webkit-nbsp-mode: space;
-webkit-line-break: after-white-space; ">As far as looking ok;
it does! With the one minor thing I mentioned to Marco about a
strange jittery panel bug on OS X that I can't seem to capture
in a screen recording. It is quite visible on screen though.</div>
</div>
</blockquote>
That's a native theming bug on Mac, it's easy to reproduce, I will
file a bug about it, but someone with OSX native theming knowledge
(smichaud or I may try asking Mano?) would take far less time
investigating it.<br>
It's a secondary issue though, doesn't break functionality and we
may fix it as a follow-up.<br>
<blockquote
cite="mid:6DFFC7ED-3277-4CD6-9E44-1183531F75CB@mozilla.com"
type="cite">
<div>
<div style="word-wrap: break-word; -webkit-nbsp-mode: space;
-webkit-line-break: after-white-space; ">
<div><br>
</div>
<div>"Should we do this" is a little more complicated. I think
yes, we should move it into its own button and out of the
awesomebar and combine the two things into one mega-button
of bookmarking awesomeness. When we were testing it there
were a few problems brought up with the interaction. 1) some
worry that combining them won't be obvious 2) the bookmark
menu is a pretty highly used item and we will be making the
hit target much smaller while the star is less commonly used
and will be larger.</div>
<div><br>
</div>
<div>We have a few ideas for refinement, but I would be ok
pushing it as is if we could iterate on it afterwards. I
don't know if that will be more or less tedious than
unbitrotting the current patch?</div>
</div>
</div>
</blockquote>
<br>
Incremental improvements would be a huge win over unbitrotting a
70KB patch!<br>
We could land soon in the 23 cycle and improve it along the way in
those 6 weeks, doing incremental improvements in 22 sounds too much
packed.<br>
<blockquote
cite="mid:6DFFC7ED-3277-4CD6-9E44-1183531F75CB@mozilla.com"
type="cite">
<div>
<div style="word-wrap: break-word; -webkit-nbsp-mode: space;
-webkit-line-break: after-white-space; ">
<div>Also uploading the try-builds here since they probably
have expired: <a moz-do-not-send="true"
href="http://people.mozilla.org/%7Eshorlander/Bookmark-Star-Builds/">http://people.mozilla.org/~shorlander/Bookmark-Star-Builds/</a></div>
<div><br>
</div>
</div>
</div>
</blockquote>
Thanks, that's much appreciated!<br>
<br>
-m<br>
</body>
</html>