Phabricator and updates to commit messages
Mark Côté
mcote at mozilla.com
Mon Oct 1 22:39:37 UTC 2018
There’s been a bit of confusion around Phabricator and updates to commit
messages lately (https://bugzilla.mozilla.org/show_bug.cgi?id=1476425).
Arcanist's default workflow is to not update a revision’s Summary field
even if the associated commit message is updated (e.g. by `hg commit
--amend`) and resubmitted via `arc diff`. This has led to people
accidentally checking in the wrong commit message.
We’ve contacted upstream about this issue, and they’ll be looking into it
after the big rewrite of Arcanist that they are currently working on (
https://secure.phabricator.com/T13098). In the meantime, there are other
ways to update the Summary:
-
The simplest is to use the web UI to edit the Summary field directly.
-
You can also use `arc diff --verbatim` when submitting updates. This
will update the Summary and some other fields from the commit message. Note
that you should first run `arc amend` or manually remove the
#secure-revision tag from the commit message. This tag is used by our
automation when setting up permissions; if you accidentally set it, you
will lock down the revision.
-
`arc diff --edit` also allows you to update the revision Summary
directly, but note that the local commit message *won’t* be correspondingly
updated unless you then run `arc amend`.
For moz-phab, we will be fixing this ourselves by calling Phabricator’s
Conduit API directly. See
https://bugzilla.mozilla.org/show_bug.cgi?id=1494372. We'll be getting to
this after git support is finalized (which is in review right now).
Mark
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.mozilla.org/pipermail/firefox-dev/attachments/20181001/f8c8aa1c/attachment.html>
More information about the firefox-dev
mailing list