XBL Replacement Newsletter #2
bgrinstead at mozilla.com
Mon Nov 27 21:18:11 UTC 2017
This is the second edition of the XBL Replacement Newsletter. Since the last update, we’ve continued to remove unused or unnecessary bindings and improved tooling to make it easier to keep track of the work and to help find candidates for removal.
Just a reminder that easiest way to follow along with the work is to follow the main meta bug <https://bugzilla.mozilla.org/show_bug.cgi?id=1397874>. If you’d like to help by removing a binding, I’ve added a whiteboard tag [xbl-available] <https://mzl.la/2AyTxCG> to mark bugs that are unblocked and have instructions in them. The list is a bit short for now but I expect that more bindings will fit that description over time, especially once Custom Element support is ready.
There are 267 more bindings left <https://bgrins.github.io/xbl-analysis/#timeline>, compared to 289 from the last update and 300 from the start of the project.
Mossop removed the inline options feature <https://bugzilla.mozilla.org/show_bug.cgi?id=1414406> that was only used by legacy add-ons, and as a result the mobile/ directory is the first top level directory to go down to zero bindings <https://bgrins.github.io/xbl-analysis/graph/#directory-bindings>! Here’s the list of bindings removed by this change: setting-base, setting-bool, setting-boolint, setting-localized-bool, setting-integer, setting-control, setting-string, setting-color, setting-path, setting-multi, setting-fulltoggle-bool, setting-fulltoggle-boolint, setting-fulltoggle-localized-bool, android-checkbox-with-spacing.
New contributor 86ecce74 removed the searchbar-treebody <https://bugzilla.mozilla.org/show_bug.cgi?id=1414020> binding by migrating the behavior into an attribute on the autocomplete-treebody binding.
86ecce74 also removed the control-item <https://bugzilla.mozilla.org/show_bug.cgi?id=1416483> binding by moving the one property it defined onto its three child bindings.
Paolo has merged together the panelmultiview and photonpanelmultiview bindings <https://bugzilla.mozilla.org/show_bug.cgi?id=1414244>. This required doing some post-photon cleanup first, like updating the site identity panel to use the new photon style <https://bugzilla.mozilla.org/show_bug.cgi?id=1409301>.
Paolo also removed the download-toolbarbutton <https://bugzilla.mozilla.org/show_bug.cgi?id=1419005> binding by allowing child content inside the toolbarbutton-badged binding that it was extending.
I removed the menucaption-inmenulist <https://bugzilla.mozilla.org/show_bug.cgi?id=1418494> binding by moving its implementation into the menucaption binding. It turns out that the only place we use menucaptions are for <optgroup>s, and they always were being bound to the inmenulist variation of the binding.
I also removed three unused statusbarpanel related bindings <https://bugzilla.mozilla.org/show_bug.cgi?id=1416368>. Some followup work to that is going to be removing the statusbar and statusbarpanel bindings <https://bugzilla.mozilla.org/show_bug.cgi?id=1416372>.
I also removed the menuseparator <https://bugzilla.mozilla.org/show_bug.cgi?id=1416493> binding by moving the accessibility role detection into C++ and loading the CSS via global.css instead of through <resources>. This surfaced an issue <https://bugzilla.mozilla.org/show_bug.cgi?id=1420229> in which we are relying on what appears to be non-standard behavior of stylesheets loaded by XBL, in which the application order of selectors is different. There’s still some discussion to be had about how to handle this situation, but moving to the standard behavior and improving tooling to detect potential issues before landing seems pretty reasonable.
Here are some noteworthy improvements to the tools and website since the last update:
The bug number and the “type” of each removal get printed on the timeline <https://bgrins.github.io/xbl-analysis/#timeline>. To make that easier, I’ve started a spreadsheet <https://docs.google.com/spreadsheets/d/1XZGCKYjcBw5D_v71ydNIrSKkC48mAqpwcKeZK9ahUkk/edit#gid=0> to track which bindings are being removed in which bugs, and which type of removal they are.
There are new graphs looking at the # of bindings per directory <https://bgrins.github.io/xbl-analysis/graph/#directory-bindings> and LOC per directory <https://bgrins.github.io/xbl-analysis/graph/#directory-loc>
The tree <https://bgrins.github.io/xbl-analysis/tree/> includes links to search m-c for each binding which makes it easier to find out where a binding is used
Binding usage data is now being gathered <https://bugzilla.mozilla.org/show_bug.cgi?id=1376546> in Nightly builds in taskcluster as the “browser-instrumentation” job. Thanks to Joel Maher and his team for making it easy to gather this data with activedata and taskcluster artifacts.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the firefox-dev