In-product SUMO links broken in non-en-US builds

Francesco Lodolo flod at lodolo.net
Wed Mar 29 22:37:42 UTC 2017


Can someone clarify how this scales for localization, given that it
looks like we're hardcoding URL redirects. What happens when we add a
new locale, or the localized article changes (and the URL changes
accordingly)?

Is this meant only to be a temporary solution?

Francesco

2017-03-29 20:16 GMT+02:00 Patrick McClard <pmcclard at mozilla.com>:
> No problem. Thanks for the update Florin.
>
> On Wed, Mar 29, 2017 at 4:31 PM, Florin Mezei <fmezei at mozilla.com> wrote:
>>
>> Hi guys,
>>
>> Quick update here: Roxana has been working on the script today, and it
>> seems she got pretty much everything set up, and only needs to fix some
>> certificate issue to have it working. We expect to have the test results for
>> you tomorrow, as Roxana had to leave.
>>
>> Regards,
>> Florin.
>>
>> On Wed, Mar 29, 2017 at 10:33 AM, Florin Mezei <fmezei at mozilla.com> wrote:
>>>
>>> Thank you Roland! I've forwarded all the information to Roxana from the
>>> Platform QA team, who will have a look at this today.
>>>
>>> Regards,
>>> Florin.
>>>
>>> On Wed, Mar 29, 2017 at 10:25 AM, Roland moco Tanglao
>>> <rtanglao at mozilla.com> wrote:
>>>>
>>>> HI Florin and QA team
>>>>
>>>> The URL being redirect to is on PRODUCUCTION NOT on stage so I've
>>>> revised my testing HOW TO appropriately. Please refer to [1] when testing.
>>>>
>>>> Cheers!
>>>>
>>>> ...Roland
>>>>
>>>> [1]
>>>> https://github.com/rtanglao/rt-li-sumo-redirects/blob/master/how-to-test-6000-redirects.md
>>>>
>>>> From Case 00137762
>>>>
>>>> Note this is automatable (I am 99% sure) via a script. Here is a proof
>>>> of concept in Ruby.
>>>>
>>>> 1. For each of the approximately 6100 rows in the spreadsheet at:
>>>>
>>>> https://docs.google.com/spreadsheets/d/1bqoCUqsCvdrGTXssavzdadTRF38l8JoIjuEJxqc2QiU/edit#gid=277128454
>>>>
>>>> A. Please test the redirection of the links in Column D to the Target
>>>> URL in Column G as follows:
>>>>
>>>> i) In the URL from Column D "Redirect this Link" e.g. row 2
>>>> https://support.mozilla.org/kb/insecure-password-warning-firefox-ach
>>>> replace support.mozilla with support-stage.allizom e.g. row 2, Column D
>>>> ->
>>>>
>>>> https://support-stage.allizom.org/kb/insecure-password-warning-firefox-ach
>>>> Let's call this URL 1
>>>> ii) Take the URL from Column G "Target URL" e.g. row 2
>>>> https://support.mozilla.org/t5/Protect-your-privacy/Insecure-password-warning-in-Firefox/ta-p/27861
>>>> Let's call this URL 2
>>>> iii) Load URL 1 in Firefox
>>>> iv) If Firefox redirects to URL 2, THEN test PASS ELSE test FAIL
>>>>
>>>>
>>>> On 3/28/17 9:53 PM, Mahendranadh Potharaju wrote:
>>>>
>>>> Status Update :
>>>>
>>>> The interim fix is in place on staging server and available for QA to
>>>> test. After QA validation we will roll out changes to production OR based on
>>>> severity of any issues, switch to Kitsune.
>>>>
>>>> For the permanent solution :
>>>> Firefox dev team and Lithium dev team had met yesterday and now have a
>>>> good understanding of the issues in this implementation. Lithium dev team is
>>>> going to present a solution by Tuesday(4/4/17) or Wednesday (4/5/17) and we
>>>> will then plan its implementation.
>>>>
>>>> Currently we are on course with intermix fix to have the links fixed in
>>>> this week.
>>>>
>>>> Thanks everyone for giving this the right attention and bringing it back
>>>> on track.
>>>>
>>>> Regards,
>>>>
>>>> Mahe
>>>>
>>>>
>>>> On Fri, Mar 24, 2017 at 11:27 AM, Mahendranadh Potharaju
>>>> <mpotharaju at mozilla.com> wrote:
>>>>>
>>>>> Here is status update from our call this morning
>>>>>
>>>>> Current Action Items :
>>>>>
>>>>> Joni is working on the links and will hand over to Lithium for the
>>>>> migration by eod Friday 3/24.
>>>>> Lithium should be able to complete migration on Tuesday 3/28
>>>>> QA team has been reached to plan testing the SUMO links on Wednesday
>>>>> 3/29
>>>>>
>>>>> Backup Plan
>>>>>
>>>>> Patrick McClard is gauging the work to migrate new content (questions,
>>>>> articles etc) in Lithium since the switch over.
>>>>> Monday, 3/27 -Giorgos will provide a time estimate to stand up Kitsune
>>>>> again and the DNS change
>>>>> If Lithium isn't able to migrate links in time or QA team fails the
>>>>> migration, we will switch over to Kitsune and figure out next course of
>>>>> action with Lithium.
>>>>>
>>>>>
>>>>> There seems to be few more links from mozilla.org and other sites which
>>>>> could be broken. Am reaching David Tenser to see who can help here to
>>>>> identify and how we can fix.
>>>>>
>>>>> Alex and Jascha are in contact with Lithium folks and are helping
>>>>> getting the necessary attention and resources.
>>>>>
>>>>> We will do daily check-ins and intend to have the links all up next
>>>>> week. Feel free to reach back with any questions.
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Mahe
>>>>>
>>>>> On Thu, Mar 23, 2017 at 1:51 PM, Giorgos Logiotatidis
>>>>> <giorgos at mozilla.com> wrote:
>>>>>>
>>>>>> + Benjamin Sternthal
>>>>>>
>>>>>>
>>>>>> Madalina Ana writes:
>>>>>>
>>>>>> > + Patrick and rest of the SUMO staff
>>>>>> >
>>>>>> > Just to clarify, we're due to finalize the spreadsheets tomorrow and
>>>>>> > send
>>>>>> > for implementation, implementation might take a few days longer.
>>>>>> >
>>>>>> > Let's check-in tomorrow 8:45 Am Pacific, I'll send out an invite.
>>>>>> >
>>>>>> > We're working on getting proper contacts for Lithium dev so that we
>>>>>> > can
>>>>>> > connect you.
>>>>>> >
>>>>>> > I'll be offline for the rest of today as I'm in CET, if you need any
>>>>>> > follow-up today please reach out to Patrick.
>>>>>> >
>>>>>> > Thanks,
>>>>>> >
>>>>>> > Madalina
>>>>>> >
>>>>>> > On Thu, Mar 23, 2017 at 9:06 PM, Mahendranadh Potharaju <
>>>>>> > mpotharaju at mozilla.com> wrote:
>>>>>> >
>>>>>> >> Thanks for jumping on a quick call Johann, Giorgos and Benjamin.
>>>>>> >>
>>>>>> >> Per Madalina's update on the bug
>>>>>> >> <https://bugzilla.mozilla.org/show_bug.cgi?id=1324426>Lithium is
>>>>>> >> working
>>>>>> >> on an interim fix which is due tomorrow. And, we need to test this
>>>>>> >> interim
>>>>>> >> fix to ensure its done right.
>>>>>> >>
>>>>>> >>
>>>>>> >> The further steps is for us to meet with Lithium engineering team
>>>>>> >> to
>>>>>> >> identify the right permanent fix and find owners to implement it on
>>>>>> >> Firefox
>>>>>> >> and/or Lithium. If its harder with Lithium folks jumping on a call
>>>>>> >> with us,
>>>>>> >> seems like they are based out of SF and we can have an in person
>>>>>> >> meeting at
>>>>>> >> Mozilla or Lithium office.
>>>>>> >>
>>>>>> >> We'll meet tomorrow and there after to drive this to finish.
>>>>>> >>
>>>>>> >> Madalina - Please propose a check-in meet time for the status.
>>>>>> >>
>>>>>> >>
>>>>>> >> Thanks,
>>>>>> >>
>>>>>> >> Mahe
>>>>>> >>
>>>>>> >>
>>>>>> >> On Thu, Mar 23, 2017 at 11:55 AM, Erin Lancaster
>>>>>> >> <elancaster at mozilla.com>
>>>>>> >> wrote:
>>>>>> >>
>>>>>> >>> If it's not too late for you, we are in my vidyo room we are on
>>>>>> >>> with some
>>>>>> >>> other folks. Thank you so much.
>>>>>> >>>
>>>>>> >>> On Thu, Mar 23, 2017 at 11:54 AM, Johann Hofmann
>>>>>> >>> <jhofmann at mozilla.com>
>>>>>> >>> wrote:
>>>>>> >>>
>>>>>> >>>> Sure, I can volunteer as a point of contact and would forward any
>>>>>> >>>> bigger
>>>>>> >>>> questions to the Firefox team.
>>>>>> >>>>
>>>>>> >>>> Thank you for acting so quickly on this! :)
>>>>>> >>>>
>>>>>> >>>> Johann
>>>>>> >>>>
>>>>>> >>>>
>>>>>> >>>> On 23/03/2017 19:34, Erin Lancaster wrote:
>>>>>> >>>>
>>>>>> >>>> Johann, Dão: Mahe is making progress figuring out who is involved
>>>>>> >>>> here
>>>>>> >>>> and what some next steps should be but we need a single point of
>>>>>> >>>> contact on
>>>>>> >>>> the Firefox engineering team. We don’t have any specific requests
>>>>>> >>>> as of yet
>>>>>> >>>> but can Mahe loop one of you in? If not, do you have someone else
>>>>>> >>>> you can
>>>>>> >>>> suggest?
>>>>>> >>>>
>>>>>> >>>> Thank you,
>>>>>> >>>> Erin
>>>>>> >>>>
>>>>>> >>>> On Mar 23, 2017, at 11:27 AM, Erin Lancaster
>>>>>> >>>> <elancaster at mozilla.com>
>>>>>> >>>> wrote:
>>>>>> >>>>
>>>>>> >>>>
>>>>>> >>>>
>>>>>> >>>> On Thu, Mar 23, 2017 at 10:14 AM, Peter Dolanjski <
>>>>>> >>>> pdolanjski at mozilla.com> wrote:
>>>>>> >>>>
>>>>>> >>>>> +Joni
>>>>>> >>>>>
>>>>>> >>>>> On Mar 23, 2017 12:19 PM, "Liz Henry (:lizzard)"
>>>>>> >>>>> <ehenry at mozilla.com>
>>>>>> >>>>> wrote:
>>>>>> >>>>>
>>>>>> >>>>>> This issue is serious enough that fixing it should be a high
>>>>>> >>>>>> priority
>>>>>> >>>>>> for Firefox 52 as well as a blocking issue for the release of
>>>>>> >>>>>> 53. I see
>>>>>> >>>>>> this as breaking a major user-facing part of our product.
>>>>>> >>>>>>
>>>>>> >>>>>> How about this as an option:  walking back to Kitsune
>>>>>> >>>>>> immediately,
>>>>>> >>>>>> until the new system is fixed *and tested* by Firefox QE.   Is
>>>>>> >>>>>> that
>>>>>> >>>>>> possible and what would it take to switch back to our working
>>>>>> >>>>>> system?
>>>>>> >>>>>>
>>>>>> >>>>>> Best
>>>>>> >>>>>>
>>>>>> >>>>>> Liz
>>>>>> >>>>>>
>>>>>> >>>>>> On Thu, Mar 23, 2017 at 7:06 AM, Johann Hofmann
>>>>>> >>>>>> <jhofmann at mozilla.com>
>>>>>> >>>>>> wrote:
>>>>>> >>>>>>
>>>>>> >>>>>>> As mentioned in the bug, this also affects most security
>>>>>> >>>>>>> information
>>>>>> >>>>>>> such as cert error pages and the in-content insecure password
>>>>>> >>>>>>> warning.
>>>>>> >>>>>>>
>>>>>> >>>>>>> The fact that it takes a long time to get this issue fixed
>>>>>> >>>>>>> does not
>>>>>> >>>>>>> speak in favor of the migration. I would really like to see an
>>>>>> >>>>>>> official
>>>>>> >>>>>>> statement explaining the reasons we are dropping Kitsune.
>>>>>> >>>>>>>
>>>>>> >>>>>>> What is unclear to me:
>>>>>> >>>>>>>
>>>>>> >>>>>>> - Why was the decision to make us depend on a proprietary
>>>>>> >>>>>>> third-party
>>>>>> >>>>>>> vendor done without feedback or announcement to any other part
>>>>>> >>>>>>> of the
>>>>>> >>>>>>> organization?
>>>>>> >>>>>>> - It seems like there were at not point any Firefox engineers
>>>>>> >>>>>>> involved in this. Why did nobody cross-check with the Firefox
>>>>>> >>>>>>> Owner/Peers?
>>>>>> >>>>>>> - No Mozilla developers were involved in testing the new
>>>>>> >>>>>>> platform
>>>>>> >>>>>>> before it went live. Testing was done by the marketing team. I
>>>>>> >>>>>>> can
>>>>>> >>>>>>> understand that resources may be limited for maintenance, but
>>>>>> >>>>>>> why was it
>>>>>> >>>>>>> decided that no engineers can be spared to integration test
>>>>>> >>>>>>> the new
>>>>>> >>>>>>> platform?
>>>>>> >>>>>>> - Is this decision in line with the module owners of SUMO?
>>>>>> >>>>>>>
>>>>>> >>>>>>> Absurdly, the modules page lists the owners of SUMO as the
>>>>>> >>>>>>> maintainers of Kitsune
>>>>>> >>>>>>> (https://wiki.mozilla.org/Modules/All#Sumo).
>>>>>> >>>>>>> Is this no longer up to date? I'd like to think the lack of
>>>>>> >>>>>>> communication
>>>>>> >>>>>>> around this is in violation of our governance policies.
>>>>>> >>>>>>>
>>>>>> >>>>>>> Johann
>>>>>> >>>>>>>
>>>>>> >>>>>>>
>>>>>> >>>>>>> On 23/03/2017 14:29, Sylvestre Ledru wrote:
>>>>>> >>>>>>>
>>>>>> >>>>>>> Hello
>>>>>> >>>>>>>
>>>>>> >>>>>>> FWIW, this has been a very important source of issue and
>>>>>> >>>>>>> frustration
>>>>>> >>>>>>> for the release management team too.
>>>>>> >>>>>>>
>>>>>> >>>>>>> This added some frictions at the end of the 52 release cycle.
>>>>>> >>>>>>>
>>>>>> >>>>>>> Sylvestre
>>>>>> >>>>>>>
>>>>>> >>>>>>> Le 23/03/2017 à 14:26, Dão Gottwald a écrit :
>>>>>> >>>>>>>
>>>>>> >>>>>>> Apparently in-product links to SUMO have been broken in
>>>>>> >>>>>>> non-en-US
>>>>>> >>>>>>> builds for at least two weeks:
>>>>>> >>>>>>>
>>>>>> >>>>>>> https://bugzilla.mozilla.org/show_bug.cgi?id=1324426#c6
>>>>>> >>>>>>>
>>>>>> >>>>>>> Two weeks passing without a resolution to this seems
>>>>>> >>>>>>> unacceptable.
>>>>>> >>>>>>>
>>>>>> >>>>>>> Why have we switched SUMO to third-party software and pulled
>>>>>> >>>>>>> our own
>>>>>> >>>>>>> engineers without at least announcing this decision through
>>>>>> >>>>>>> the appropriate
>>>>>> >>>>>>> channels (this includes this mailing list) to allow people to
>>>>>> >>>>>>> voice
>>>>>> >>>>>>> concerns as to what this means for our products?
>>>>>> >>>>>>>
>>>>>> >>>>>>> Can we switch back from Lithium and resource SUMO
>>>>>> >>>>>>> appropriately again?
>>>>>> >>>>>>>
>>>>>> >>>>>>> dao
>>>>>> >>>>>>>
>>>>>> >>>>>>>
>>>>>> >>>>>>> _______________________________________________
>>>>>> >>>>>>> firefox-dev mailing
>>>>>> >>>>>>> listfirefox-dev at mozilla.orghttps://mail.mozilla.org/listinfo/firefox-dev
>>>>>> >>>>>>>
>>>>>> >>>>>>> WIW
>>>>>> >>>>>>>
>>>>>> >>>>>>> _______________________________________________ firefox-dev
>>>>>> >>>>>>> mailing
>>>>>> >>>>>>> list firefox-dev at mozilla.org https://mail.mozilla.org/listi
>>>>>> >>>>>>> nfo/firefox-dev
>>>>>> >>>>>>
>>>>>> >>>>>> --
>>>>>> >>>>>> ----
>>>>>> >>>>>> Liz Henry (:lizzard)
>>>>>> >>>>>> Firefox Release Manager
>>>>>> >>>>>> lhenry at mozilla.com
>>>>>> >>>>>> _______________________________________________ firefox-dev
>>>>>> >>>>>> mailing
>>>>>> >>>>>> list firefox-dev at mozilla.org https://mail.mozilla.org/listi
>>>>>> >>>>>> nfo/firefox-dev
>>>>>> >>>>>
>>>>>> >>>>> _______________________________________________ firefox-dev
>>>>>> >>>>> mailing
>>>>>> >>>>> list firefox-dev at mozilla.org https://mail.mozilla.org/listi
>>>>>> >>>>> nfo/firefox-dev
>>>>>> >>>>
>>>>>> >>>>
>>>>>> >>>
>>>>>> >>
>>>>>> >>
>>>>>> >> --
>>>>>> >> Mahendra Potharaju
>>>>>> >>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Mahendra Potharaju
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Mahendra Potharaju
>>>>
>>>>
>>>
>>
>
>
> _______________________________________________
> firefox-dev mailing list
> firefox-dev at mozilla.org
> https://mail.mozilla.org/listinfo/firefox-dev
>



More information about the firefox-dev mailing list