Bug 492557: Brainstorming

Gavin Sharp gavin at gavinsharp.com
Wed Oct 2 14:37:23 UTC 2013

On Tue, Oct 1, 2013 at 11:33 PM, James Hobin <hobinjk at mit.edu> wrote:
> My best idea so far is to
> go to every undocumented keyboard shortcut and turn it into a proper set
> of <key>, <command>, and <menuitem> elements. This will introduce quite
> a few locale-specific strings (which should have already been translated
> for the SUMO page). The biggest wins for this approach are allowing
> every keyboard shortcut to be locale-specific (for example, French
> keyboards make Ctrl-` not make any sense), paving the way for an
> official keyboard shortcut rebinding mechanism, and reducing code
> inconsistency. I'm most concerned that adding all of this will somehow
> decrease performance or increase memory usage.

Switching to <key>, <command>, and <menuitem>s sounds like the right
approach in general. If the keys aren't currently localizable, we
don't necessarily need to make them so when converting to
<key>/<command>/<menuitem>, they can just stay hard coded. Making them
localizable may be the right decision, but we don't need to tie it to
this change if it ends up being controversial.


More information about the firefox-dev mailing list