<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>Georg, what did you mean by "Without using a keyed histogram, the
label definition would be repeated over multiple histogram
definitions."?</p>
<br>
<div class="moz-cite-prefix">On 3/2/17 08:18, Georg Fritzsche wrote:<br>
</div>
<blockquote
cite="mid:CAPdcD_cmUp_feeP7SmHCuYX8iuZJmECHOf6D5gZbq7-vO41mNw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>Originally we added keyed histograms to allow using string
keys that were not all known before.<br>
However, we have use-cases were it makes sense to use the
two-level keyed histogram structure (name, key), even when the
set of keys is known before (e.g. to share common
definitions).<br>
</div>
<div><br>
So in <a moz-do-not-send="true"
href="https://bugzilla.mozilla.org/show_bug.cgi?id=1343855">bug
1343855</a> we plan to add an additional optional field
"keys" for keyed histograms that allows specifying the valid
key strings.<br>
</div>
<div>Any recording to the histogram with an invalid key string
will be ignored and a warning/error be print<br>
</div>
<div><br>
E.g. consider:<br>
<div>"STORAGE_UPDATE_RESULT": {<br>
</div>
"keyed": true,<br>
</div>
<div> "kind": "categorical",<br>
</div>
<div> "keys": ["blocklists.addons", "blocklists.certificates",
"pinning.pins"],<br>
</div>
<div> "labels": ["success", "backoff", "network_error",
"server_error", "sign_error"],<br>
...<br>
}<br>
<br>
</div>
<div>Without using a keyed histogram, the label definition would
be repeated over multiple histogram definitions.<br>
<br>
</div>
<div>Feedback, concerns?<br>
<br>
</div>
<div>Georg<br>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
fhr-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:fhr-dev@mozilla.org">fhr-dev@mozilla.org</a>
<a class="moz-txt-link-freetext" href="https://mail.mozilla.org/listinfo/fhr-dev">https://mail.mozilla.org/listinfo/fhr-dev</a>
</pre>
</blockquote>
<br>
</body>
</html>