Expiration question

[Benjamin Smedberg]

How about we change the behavior and call it "expires_after".

--BDS

On Mon, Mar 6, 2017 at 10:29 AM, Georg Fritzsche <gfritzsche at mozilla.com>
wrote:

> We seem to have this coming up repeatedly.
> What naming would be more clear?
> "recording_stops_in_version"?
>
> Currently we use:
> - Histograms.json uses "expires_in_version"
> - Scalars.yaml uses "expires"
> - Events.yaml uses "expiry_version"
>
> We should end up using common field names and make them less confusing.
>
> Georg
>
> On Mon, Mar 6, 2017 at 3:55 PM, Alessio Placitelli <
> aplacitelli at mozilla.com> wrote:
>
>> It means that it stops being recorded in 55, see
>> http://searchfox.org/mozilla-central/source/toolkit/componen
>> ts/telemetry/TelemetryCommon.cpp#28
>>
>> 2017-03-06 15:42 GMT+01:00 Benjamin Smedberg <benjamin at smedbergs.us>:
>>
>>> When a histogram expires_in: 55, does that mean that it is recorded
>>> until Firefox 56, or that it stops being recorded in 55?
>>>
>>> I always assumed that expires_in: 55 meant that it stopped being
>>> recorded in Firefox 56, but seeing some recent alert emails has made me
>>> less sure.
>>>
>>> --BDS
>>>
>>> _______________________________________________
>>> fhr-dev mailing list
>>> fhr-dev at mozilla.org
>>> https://mail.mozilla.org/listinfo/fhr-dev
>>>
>>>
>>
>> _______________________________________________
>> fhr-dev mailing list
>> fhr-dev at mozilla.org
>> https://mail.mozilla.org/listinfo/fhr-dev
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.mozilla.org/pipermail/fhr-dev/attachments/20170306/c99e6190/attachment-0001.html>