Telemetry+FHR v4: Submission policy

[Brendan Colloran]

In the design doc--
https://docs.google.com/a/mozilla.com/document/d/1IGpzsYGi_sq3YFQDAPyKOkU_BKvXAC95fZYA2i4ceVs/edit#heading=h.kdz9l9vsn2d9
-- we have the following:

"""
Ping Retention and Upload

Pings are saved on the client for a period of time (180 days for main
pings; may be shorter for other pings types). As soon as a ping is
complete, it is sent to the Mozilla analysis server. In case of
sending errors, the client will retry several times. The client
assumes that once it has received a 200/201/202 HTTP response for a
ping, that it has been received successfully.
"""

I thought we'd discussed the need to keep trying to resubmit a session
fragment until an ack is received (i.e., two times will not
necessarily be enough). I would certainly be worried about data loss
if we make at most two submission attempts.


On Mon, Jan 26, 2015 at 10:40 AM, Mark Reid <mreid at mozilla.com> wrote:
> Thanks Nick, that is helpful.  Can someone confirm the client behaviour in
> the Telemetry code?
>
> Thanks,
> Mark
>
> On Mon, Jan 26, 2015 at 2:32 PM, Nicholas Alexander <nalexander at mozilla.com>
> wrote:
>>
>> Hi Mark,
>>
>> On Mon, Jan 26, 2015 at 9:50 AM, Mark Reid <mreid at mozilla.com> wrote:
>>>
>>> Hi all,
>>>
>>> As far as I know, the client currently doesn't retry if a submission
>>> fails.
>>>
>>> This would have minimal impact in the "old" FHR scheme, since each
>>> submission contains the entire history for that client.
>>>
>>> In the new scheme, however, this would result in potential data loss.
>>>
>>> I requested that we clarify the submission policy on the client in bug
>>> 1124212, but should we continue with the "try once, then move on" policy? or
>>> revisit client-side behaviour?
>>>
>>> If I'm mistaken and the client already retries, please let me know.
>>
>>
>> I believe that both Desktop and Android FHR clients try to resubmit.
>> Desktop's policy is described at [1].  It is possible Desktop's code has
>> diverged.  Android's policy copied Desktop's and is described at [2].  Both
>> policies explicitly claim to retry at most twice, delaying by at least one
>> hour between each submission (IIRC).
>>
>> Hope that helps!
>> Nick
>>
>> [1]
>> https://dxr.mozilla.org/mozilla-central/source/services/datareporting/policy.jsm#197
>> [2]
>> https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/background/healthreport/upload/SubmissionPolicy.java#40
>>
>
>
> _______________________________________________
> fhr-dev mailing list
> fhr-dev at mozilla.org
> https://mail.mozilla.org/listinfo/fhr-dev
>