About bugfix: For ISO 8601 syntax, Date.parse should accept " " in places where "T" is allowed

Norbert Lindenberg ecmascript at norbertlindenberg.com
Tue Sep 18 14:05:37 PDT 2012


Hi Colin,

When changing the implementation of a standard built-in function that's defined in the ECMAScript Language Specification, you should always check the specification:
http://ecma-international.org/ecma-262/5.1/

In this case, it seems your extension of the accepted formats is allowed by the statement "the function may fall back to any implementation-specific heuristics or implementation-specific date formats".
http://ecma-international.org/ecma-262/5.1/#sec-15.9.4.2

Norbert


On Sep 17, 2012, at 0:53 , LittleQ wrote:

> I made a patch for bug-791320 [1], and somebody ask me to get opinions from this mailing list.
> 
> This patch added support for accepting " " in places where "T" is allowed originally, will it cause any problem.
> 
> for example:
> 
> "2012-12-12T12:12:12" and the derivation(append millisecond or timezone) will be accepted.
> "2012-12-12 12:12:12" will be accepted after this patch
> 
> and these won't be accepted after this modifying:
> 
> "2012-12-12A12:12:12" (A could be replaced by a-zA-Z)
> "2012-12-12-12:12:12"
> "2012-12-12:12:12:12"
> 
> any comment for this fixing?
> 
> Thanks, this is my first patch for firefox :) any advise will be welcome~
> 
> [1] For ISO 8601 syntax, Date.parse should accept " " in places where "T" is allowed.: https://bugzilla.mozilla.org/show_bug.cgi?id=791320
> 
> -- 
> {
>     greeting: "Have a nice day!",
>     name: "Colin Su",
>     nickname: "LittleQ",
>     email: "littleq0903 at gmail.com",
>     website: "http://about.me/littleq",
>     title: [
>         ["Genie Capital", "Web Developer"],
>         ["National Chengchi University", "Student", "Computer Science Dept."]
>     ]
> }
> 
> _______________________________________________
> es-discuss mailing list
> es-discuss at mozilla.org
> https://mail.mozilla.org/listinfo/es-discuss



More information about the es-discuss mailing list