<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Sep 25, 2017 at 6:50 AM, Ryan Kelly <span dir="ltr"><<a href="mailto:rfkelly@mozilla.com" target="_blank">rfkelly@mozilla.com</a>></span> wrote:<br><div>  </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail-m_6056661774936543872gmail-h5"><div class="gmail_quote"><span class="gmail-"><div></div></span><div>AFAICT, Firefox used context=fx_desktop_v1 up until Firefox 45 and our switch to webchannels in this bug:</div><div><br></div><div>  <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=1218022" target="_blank">https://bugzilla.mozilla.org/<wbr>show_bug.cgi?id=1218022</a></div><div><br></div><div>If then used context=fx_desktop_v2 for a while one release, when we landed this bug for Firefox 46:</div><div><br></div><div>  <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=1204714" target="_blank">https://bugzilla.mozilla.org/<wbr>show_bug.cgi?id=1204714</a></div><div><br></div><div>So IIUC dropping support for those two integrations would disable Fxa login on Firefox 45 and earlier, which seems reasonable to me.</div></div></div></div></div></blockquote><div><br></div><div>fx_desktop_v1 and fx_desktop_v2 are the two that cause the most slowdown. I'd also like to get rid of fx_firstrun_v1. fx_firstrun_v2 was used beginning with Firefox 46:</div><div><br></div><div><a href="https://github.com/mozilla/bedrock/pull/3851">https://github.com/mozilla/bedrock/pull/3851</a></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail-m_6056661774936543872gmail-h5"><div class="gmail_quote"><div><br></div><div>That said, I'll note that the fx_ios_v1 broker currently extends fx_desktop_v1:</div><div><br></div><div>  <a href="https://github.com/mozilla/fxa-content-server/blob/master/app/scripts/models/auth_brokers/fx-ios-v1.js" target="_blank">https://github.com/mozilla/<wbr>fxa-content-server/blob/<wbr>master/app/scripts/models/<wbr>auth_brokers/fx-ios-v1.js</a></div><div><br></div><div>So we'll have to double-check that we don't accidentally lose test coverage for iOS if we remove the desktop version.<br></div></div></div></div></div></blockquote><div><br></div><div><br></div><div>This also needs to be considered for fx_desktop_v2=>fx_desktop_v3 and fx_firstrun_v1=>fx_firstrun_v2. I want to speed up development, but not at the expense of broken supported flows.</div><div><br></div><div>Shane</div></div></div></div>