How can I change an add-on's _execute_browser_action command?

Andrew McKay amckay at mozilla.com
Thu Oct 19 03:24:22 UTC 2017


That's the one! Thanks for finding that Eric.

On 18 October 2017 at 18:32, Eric Promislow <eric.promislow at gmail.com> wrote:
> https://bugzilla.mozilla.org/show_bug.cgi?id=1348589 does what I want --
> and I would leave 1303384 in place for addons that would prefer to point
> their users to a common UI
>
> On Wed, Oct 18, 2017 at 3:00 PM, Andrew McKay <amckay at mozilla.com> wrote:
>>
>> Yep, that's how we'd do it. I'm about 90% sure I filed a bug for that
>> in Bugzilla, but I can't find it right now. If you could file a bug
>> for that please and block on bug 1303384 someone could then pick it
>> up.
>>
>> Of course, then I'll probably find the bug I filed...
>>
>> On 18 October 2017 at 16:15, Eric Promislow <eric.promislow at gmail.com>
>> wrote:
>> > Interesting. I imagine that a `commands.update` command might be easier
>> > to
>> > implement than the full API page with nice UI. From reading
>> >
>> > https://dxr.mozilla.org/mozilla-central/source/browser/components/extensions/ext-commands.js
>> > it looks like it's a matter of updating each browser window's keyset.
>> >
>> > So what's involved in modifying the API? Obviously more than adding a
>> > field
>> > to ext-commands.js and documenting it. I see the w3c is recognizing a
>> > Browser Extension Community Group .  It defines a core API (at
>> > https://browserext.github.io/browserext ), but `commands` isn't in that
>> > list. So can Mozilla duly proceed to add an `update` method?
>> >
>> > - Eric
>> >
>> >
>> > On Tue, Oct 17, 2017 at 11:03 PM, Michael Buckley
>> > <support at codefisher.org>
>> > wrote:
>> >>
>> >> https://bugzilla.mozilla.org/show_bug.cgi?id=1303384
>> >>
>> >> God Bless
>> >>
>> >> Michael
>> >>
>> >>
>> >> On 18/10/17 4:04 pm, Eric Promislow wrote:
>> >>
>> >> The only supported method in the commands API is 'getAll'.
>> >>
>> >> Chrome supports 'chrome://extensions/configureCommands' which lets the
>> >> add-on user set each installed add-on's startup key.
>> >>
>> >> This doesn't look supported in Firefox. Is there a roadmap to either
>> >> provide
>> >> a commands.update method (signature: command name, object payload),
>> >> or build a page like Chrome has?
>> >>
>> >> After being around for 8 years, Tabhunter users have expected to be
>> >> able
>> >> to set their preferred keyboard shortcut for launching it. Is there a
>> >> better
>> >> alternative to crafting a custom manifest.json for each user?
>> >>
>> >> - Eric
>> >>
>> >>
>> >> _______________________________________________
>> >> Dev-addons mailing list
>> >> Dev-addons at mozilla.org
>> >> https://mail.mozilla.org/listinfo/dev-addons
>> >>
>> >>
>> >>
>> >> _______________________________________________
>> >> Dev-addons mailing list
>> >> Dev-addons at mozilla.org
>> >> https://mail.mozilla.org/listinfo/dev-addons
>> >>
>> >
>> >
>> > _______________________________________________
>> > Dev-addons mailing list
>> > Dev-addons at mozilla.org
>> > https://mail.mozilla.org/listinfo/dev-addons
>> >
>
>


More information about the Dev-addons mailing list